GoodWe firmware version breaks the es config after update about goodwe

[mletenay]

I assume it failed on line 160, but the previous version with base=16.
The base=36 is the fixed done here 327c780 and I'm going to make a release with it soon.

[DarthV02]

Come on! Nothing to apologize for, we really appreciate the amazing job you do!
Many thanks for the response and the fixing!
Enjoy the rest of the summer you all. 😊

[NielZeeman]

Great. Thanks a lot!!

[DarthV02]

Hi @mletenay ,

My appologies in advance since i might not be writting into the right channel/topic, but:

I'm runing Home Assistant Supervised on Debian 10, updated to the last version core-2022.7.6, and i'm not able to install the Goodwe Inverter integration from the integrations repository UI. As the colleague @NielZeeman, I get the following log error when doing the set up through the integrations UI menu on Home Assistant:

Logger: aiohttp.server
Source: components/goodwe/config_flow.py:36
First occurred: 11:43:15 AM (1 occurrences)
Last logged: 11:43:15 AM

last call from the log:
File "/usr/local/lib/python3.10/site-packages/goodwe/es.py", line 160, in read_device_info
self.arm_sw_version = int(self.arm_version[4], base=16)
ValueError: invalid literal for int() with base 16: 'G'

I see you said 16 days ago you will fix it, and going through the code on the es.py file in this github repository:

marcelblijleven

I can already see that you fixed the issue on line 160 --> base=16 to base=36, but when going through the documentation in this other repository, which I believe is the one that really belongs to Home Assistant:

https://github.com/home-assistant/core/tree/dev/homeassistant/components/goodwe

I don't see the py.es file nowhere and can't modify the base, as you also explain in this post:

https://packagegalaxy.com/python/goodwe

Latley i came across another change you indicated in the manifest.json file, changing the "requirements": ["goodwe==0.2.15"], to "requirements": ["goodwe==0.2.18"],

this is what i see on the homeassistant repository:
{
"domain": "goodwe",
"name": "GoodWe Inverter",
"documentation": "https://www.home-assistant.io/integrations/goodwe",
"codeowners": ["@mletenay", "@starkillerOG"],
"requirements": ["goodwe==0.2.15"],
"config_flow": true,
"iot_class": "local_polling",
"loggers": ["goodwe"]
}

Thanks for your support and looking forward to your reply :)
Aitor.

[DarthV02]

My inverter was updated to version 2424G This seems to break on the following line: (es.py:160) self.arm_sw_version = int(self.arm_version[4], base=36)

Hi @NielZeeman, as you will see on the chat que, I also commented on this issue, as i have the same problem you posted.
I understand (from their comments) that the programmers are working on it, but the goodwe inverter official integration for Home Assistant Supervised, isn't still working for me... the base=16 issue keeps popping up when traying to install it.

Just to check whether i am doing something wrong, would you please let me know if you have it up and running?
Thanks in advance! :)

Aitor.

[starkillerOG]

The issue schould have been fixed with this PR: home-assistant/core#75615
This fix is included in HomeAssistant version 2022.08.x.
Sorry for the late replay, it is vacation time...