GithubHelp home page GithubHelp logo

Comments (6)

marcelblijleven avatar marcelblijleven commented on August 11, 2024

Hi, sounds good! Will join the discord channel later this evening

from goodwe.

marcelblijleven avatar marcelblijleven commented on August 11, 2024

@mletenay the discord link seems to be expired

from goodwe.

mletenay avatar mletenay commented on August 11, 2024

Weird, try this one - https://discord.gg/CAZVTDsB

from goodwe.

mletenay avatar mletenay commented on August 11, 2024

I merged all my code into your repository, made same changes also to your code but so far did not change any of your APIs.
(During the merge I've found out the XS protocol is actually the same one as DT and D-NS inverters use.)
Please, take a look at my code changes, let me know if you dislike anything.
We should now decide how to proceed and adjust existing APIs and publish new one.
I suggest to use my Inverter classes instead of your Processors, since the inverter can not only process (single request) result, but has broader API, including methods for reading inverter settings or for setting inverter work mode etc ...

from goodwe.

mletenay avatar mletenay commented on August 11, 2024

I think the code is getting ready for some release.
(And yes, looking at the amount of code and its changes it looks like I hijacked your repo ;-).
How are we going to proceed ?
Are you willing to add me as another maintainer to pypi so I can do it on my own ?
Anyway, feel free to comment/criticize the code and suggest any improvement...

from goodwe.

marcelblijleven avatar marcelblijleven commented on August 11, 2024

Hi @mletenay I haven't got the time to look into things much, busy at work and life at the moment, but if you want you can trigger the release from GitHub. It automatically builds the package and pushes it to PyPi when you create a new release from Github.

If you want, I can create it for you but feel free to try it out yourself.

from goodwe.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.