Unwanted functionality or bug: .php files shall not be scanned if MIME type not satisfied about php-antimalware-scanner

[milosdjakonovic]

Definitely needs better approach then what I did initially. New PR will be ready soon.
Basically, public static $extensions should be scanned by default regardless of MIME type.

I have also introduced a non-default --all option to scan absolutely everything readable: according to early estimations, ~3 fold longer scan times on Wordpress site. Speaking for myself, not a big deal.

[marcocesarato]

Hi @milosdjakonovic , merged and released on v0.10.0. Thank for your pull request and your support 👍

[milosdjakonovic]

It seems to me that PAS is restricting file scan criteria to a set of defined extensions ( public static $extensions ), and then further to text/ MIME.

What do you think about changing this? Maybe it is best to scan everything that is PHP? It does sound good to me but, there is a sub-issue how to do it in practice. An extremely performance-efficient solution would be:

grep -ir "<?php" /path/to/targetdir

and then to construct iterator from returned list, plus PHP fallback for absence of grep command.

Than it would be near complete: the only malware code that would be able to escape this would be php code without open tag, something that would require a different including / executing strategy (rarely existing).

A complete solution would be, yes 😀 scan absolutely everything that is readable, I cannot even get the picture how many times would the scan duration be multiplied.