GithubHelp home page GithubHelp logo

Possible bugs in demo trail.py? about vedo HOT 4 CLOSED

marcomusy avatar marcomusy commented on September 6, 2024
Possible bugs in demo trail.py?

from vedo.

Comments (4)

marcomusy avatar marcomusy commented on September 6, 2024

Thanks Guillaume for spotting these problems,
the RenderPointsAsSpheresOn indeed is only present in later vtk versions, so i will add a version check to that specific line.
for the moment you can comment out that line.

your python doesn't seem to support f-strings, probably a macOS issue (?) .. i need to investigate that..
cheers, marco

from vedo.

Gjacquenot avatar Gjacquenot commented on September 6, 2024
  • f-strings were introduced in Python 3.6
  • RenderPointsAsSpheresOn is accessible from VTK 8.0

These two bugs can be fixed by updating setup.py:

  • delete support for Python2.7 and Python3.5
  • specify a version for VTK.

VTK is specified as a depency twice in the requirements.txt and in setup.py.
I would recommend to specify it once in requirements.txt and read the dependency from the setup.py

from vedo.

marcomusy avatar marcomusy commented on September 6, 2024

Yes- that makes sense, i will commit these changes along with others early next week, thanks.

from vedo.

marcomusy avatar marcomusy commented on September 6, 2024

Hi Guillaume
I added version.py so it's now picking it from a single source.
I would not drop python2 support for the moment as - i understand - it will be deprecated only by end of next year..
Cheers

from vedo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.