Please add favicon.ico about yt-dlp-web-ui

[marcopeocchi]

Hello @0x6d61726b,

The icon looks fine :)
Surely better than nothing. I'll try to add it ASAP.

[0x6d61726b]

Wow, that was quick, thank you very much. :-)
I thought: take the icon already present and apply the yt color. Unfortunately, I didn't know on how to include it, so it gets build/delivered.

I just fetched the current master branch and tried a build, but somehow the favicon.ico file is not embedded? At least I still get 404 Not Found. The changes in index.html are present when delivered to the browser.

# npm run build

> [email protected] build
> vite build

The CJS build of Vite's Node API is deprecated. See https://vitejs.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated for more details.
vite v5.1.4 building for production...
transforming (1) index.html
  ⚡ Million.js 2.6.4
  - Tip:     use // million-ignore for errors
  - Hotline: https://million.dev/hotline

node_modules/fp-ts/es6/TaskEither.js (962:0) A comment

"/*#__PURE__*/"

in "node_modules/fp-ts/es6/TaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
node_modules/fp-ts/lib/TaskEither.js (1002:0) A comment

"/*#__PURE__*/"

in "node_modules/fp-ts/lib/TaskEither.js" contains an annotation that Rollup cannot interpret due to the position of the comment. The comment will be removed to avoid issues.
✓ 12143 modules transformed.
dist/index.html                                                   0.51 kB │ gzip:   0.33 kB
dist/assets/roboto-mono-vietnamese-400-normal-BJn9WoS4.woff2      4.69 kB
dist/assets/roboto-vietnamese-500-normal-Bwg8Dbh6.woff            4.73 kB
dist/assets/roboto-vietnamese-700-normal-Mc0c6qif.woff            4.73 kB
dist/assets/roboto-vietnamese-400-normal-BkEBOAV9.woff            4.75 kB
dist/assets/roboto-vietnamese-300-normal-DOxDZ6bW.woff            4.77 kB
dist/assets/roboto-vietnamese-300-normal-CnPrVvBs.woff2           5.47 kB
dist/assets/roboto-vietnamese-700-normal-SekShQfT.woff2           5.55 kB
dist/assets/roboto-vietnamese-400-normal-kCRe3VZk.woff2           5.56 kB
dist/assets/roboto-vietnamese-500-normal-CcijQRVW.woff2           5.60 kB
dist/assets/roboto-mono-vietnamese-400-normal-BJbtp2UX.woff       5.92 kB
dist/assets/roboto-mono-greek-400-normal-BdERMBEW.woff2           6.02 kB
dist/assets/roboto-greek-700-normal-CjuTpGfE.woff                 6.30 kB
dist/assets/roboto-greek-500-normal-CVjdsdX9.woff                 6.32 kB
dist/assets/roboto-greek-400-normal-BnGNaKeW.woff                 6.35 kB
dist/assets/roboto-greek-300-normal-Dgbe-dnN.woff                 6.44 kB
dist/assets/roboto-greek-700-normal-Cc2Tq8FV.woff2                6.94 kB
dist/assets/roboto-greek-500-normal-CpESfwfG.woff2                7.02 kB
dist/assets/roboto-greek-400-normal-BRWHCUYo.woff2                7.11 kB
dist/assets/roboto-greek-300-normal-ndiuWqED.woff2                7.12 kB
dist/assets/roboto-mono-greek-400-normal-Dp0HotGv.woff            7.20 kB
dist/assets/roboto-mono-cyrillic-400-normal-DEN69lup.woff2        7.39 kB
dist/assets/roboto-cyrillic-400-normal-DCQqOlfN.woff              8.39 kB
dist/assets/roboto-cyrillic-300-normal-UX5PCucy.woff              8.43 kB
dist/assets/roboto-cyrillic-700-normal-DAIxw5xX.woff              8.66 kB
dist/assets/roboto-cyrillic-500-normal-QpWeYsca.woff              8.70 kB
dist/assets/roboto-mono-cyrillic-400-normal-B6g5SoKk.woff         9.12 kB
dist/assets/roboto-mono-latin-ext-400-normal-D_EPU6CM.woff2       9.56 kB
dist/assets/roboto-cyrillic-300-normal-D6mjswgs.woff2             9.58 kB
dist/assets/roboto-cyrillic-400-normal-DVDTZtmW.woff2             9.63 kB
dist/assets/roboto-cyrillic-700-normal-B5ZBKWCH.woff2             9.64 kB
dist/assets/roboto-cyrillic-500-normal-DAkZhMOh.woff2             9.84 kB
dist/assets/roboto-latin-ext-700-normal-DwUXTeTv.woff            10.17 kB
dist/assets/roboto-latin-ext-500-normal-B9pAx_JH.woff            10.18 kB
dist/assets/roboto-latin-ext-400-normal-DloBNwoc.woff            10.21 kB
dist/assets/roboto-latin-ext-300-normal-CaUuWeqj.woff            10.36 kB
dist/assets/roboto-latin-ext-300-normal-DEsNdRC-.woff2           11.80 kB
dist/assets/roboto-latin-ext-500-normal-BWKy6SgX.woff2           11.80 kB
dist/assets/roboto-latin-ext-700-normal-BYGCo3Go.woff2           11.82 kB
dist/assets/roboto-latin-ext-400-normal-4bLplyDh.woff2           11.87 kB
dist/assets/roboto-mono-latin-ext-400-normal-CFnj-Ilb.woff       12.23 kB
dist/assets/roboto-mono-latin-400-normal-C_5wUCW5.woff2          12.76 kB
dist/assets/roboto-cyrillic-ext-700-normal-dDOtDc5i.woff         13.43 kB
dist/assets/roboto-cyrillic-ext-500-normal-sraxM_lR.woff         13.45 kB
dist/assets/roboto-cyrillic-ext-400-normal--KougVX-.woff         13.47 kB
dist/assets/roboto-cyrillic-ext-300-normal-C7AGhuC_.woff         13.55 kB
dist/assets/roboto-mono-cyrillic-ext-400-normal-Q6o0JNvR.woff2   13.70 kB
dist/assets/roboto-latin-400-normal-BU1SoK4h.woff                14.38 kB
dist/assets/roboto-latin-700-normal-Bh431LEL.woff                14.42 kB
dist/assets/roboto-latin-500-normal-Dcm-rhWF.woff                14.42 kB
dist/assets/roboto-latin-300-normal-lq7MgJXa.woff                14.59 kB
dist/assets/roboto-cyrillic-ext-700-normal-CsrCEJIc.woff2        14.68 kB
dist/assets/roboto-cyrillic-ext-500-normal-G9W8hgzQ.woff2        14.97 kB
dist/assets/roboto-cyrillic-ext-300-normal-TzZWIuiO.woff2        15.00 kB
dist/assets/roboto-cyrillic-ext-400-normal-DORK9bGA.woff2        15.34 kB
dist/assets/roboto-latin-300-normal-ThHrQhYb.woff2               15.74 kB
dist/assets/roboto-latin-400-normal-mTIRXP6Y.woff2               15.74 kB
dist/assets/roboto-mono-latin-400-normal-B0u6u4eV.woff           15.83 kB
dist/assets/roboto-latin-700-normal-CeM5gOv8.woff2               15.86 kB
dist/assets/roboto-latin-500-normal-Dxdx3aXO.woff2               15.92 kB
dist/assets/roboto-mono-cyrillic-ext-400-normal-C4uWV10k.woff    17.69 kB
dist/assets/index-uBNPRR5b.css                                   25.03 kB │ gzip:  10.45 kB
dist/assets/ErrorBoundary-24WrUvCb.js                             1.24 kB │ gzip:   0.64 kB
dist/assets/Login-q1gqouZ-.js                                     1.77 kB │ gzip:   0.95 kB
dist/assets/map-R9VLo-pO.js                                       3.67 kB │ gzip:   1.46 kB
dist/assets/Checkbox-DYaHfmQZ.js                                  4.48 kB │ gzip:   1.97 kB
dist/assets/Button-D1YZQJ2_.js                                    7.22 kB │ gzip:   2.05 kB
dist/assets/argsParser-rfjCXfyk.js                               11.17 kB │ gzip:   4.11 kB
dist/assets/Settings-ByPu0xCF.js                                 12.34 kB │ gzip:   4.51 kB
dist/assets/Archive-DPFVGC2Z.js                                  20.53 kB │ gzip:   7.20 kB
dist/assets/Either-DTCH8sFe.js                                   28.66 kB │ gzip:   8.05 kB
dist/assets/TaskEither-D6nan_Vz.js                               44.75 kB │ gzip:  10.63 kB
dist/assets/TextField-CEDQ5EbC.js                                49.28 kB │ gzip:  14.73 kB
dist/assets/DeleteForever-BnBBGSEw.js                            51.58 kB │ gzip:  17.61 kB
dist/assets/Home-Cgl0D9mb.js                                     77.13 kB │ gzip:  22.22 kB
dist/assets/index-Dmmd3bAC.js                                   497.35 kB │ gzip: 160.81 kB
✓ built in 9.90s

Did I miss something during building?

[marcopeocchi]

I see. In the main.go the public directory isn't embedded.

[marcopeocchi]

I moved the favicon to the src/assets folder so Rollup can bundle it correctly

[0x6d61726b]

I did a new build and it works perfectly. Thanks a lot. :-)