Comments (4)
Thanks for reporting this @stephannv.
I don't think we can really support this, unless we hard code a list of attributes which should get forced to a boolean. Probably something like:
BOOLEAN_ATTRIBUTES = ["required", "disabled", "checked", "hidden", "readonly"]
But on the other hand, the output Phlexing is providing is not wrong, HTML boolean can either be written as:
<input required>
<input required="">
or:
<input required="required">
All of them are equally valid. MDN says:
If a boolean attribute is present, its value is true, and if it's absent, its value is false.
To be clear, the values "true" and "false" are not allowed on boolean attributes. To represent a false value, the attribute has to be omitted altogether.
So I'm not sure if this (and/or the boolean attribute mapping) should be handled here or in Phlex itself. Any thoughts?
from phlexing.
I think it's not necessary to map all the possible boolean attributes, because some js frameworks can create new boolean attributes every day, eg. <v-input clearable>
. I think this behavior should be simple: if <tag attribute>
then tag(attribute: true)
, if <tag attribute="">
then tag(attribute: "")
.
I wrote some tests for this behavior:
it "should convert boolean attributes properly" do
html = %(<input required>)
expected = <<~PHLEX.strip
input(required: true)
PHLEX
assert_phlex_template expected, html
end
it "should convert blank attributes properly" do
html = %(<input required="">)
expected = <<~PHLEX.strip
input(required: "")
PHLEX
assert_phlex_template expected, html
end
But Nokogiri #value
is always returning ""
to <input required>
and <input required="">
, so I think this can be unfeasible due to Nokogiri behavior.
from phlexing.
Thanks for providing some test-cases! I think that would make sense.
But Nokogiri #value is always returning "" to and , so I think this can be unfeasible due to Nokogiri behavior.
Yeah, I guess that's the root cause of the issue. I wonder if there's another method inside Nokogiri we might be able to use for that!
from phlexing.
@marcoroth I found a solution, but I don't know if it's the best solution: #120
from phlexing.
Related Issues (20)
- Uppercase tag names
- ivars and locals used in ERB attribute interpolation are not respected when generating the `initialize` method
- `<header>` gets treated as `<head>`
- ERB in attributes always outputs parens HOT 1
- ERB attribute interpolation with one static and one dynamic string HOT 5
- More than one ERB interpolation in HTML attribute
- Rails `t` and `translate` helpers
- Style tags gets minified/transformed
- More than one ERB string interpolation in HTML attribute HOT 1
- ERB interpolation within `<style>` tag doesn't work
- Stray `text` calls on method calls that render or capture for `Phlex::DeferredRender HOT 1
- SVG tags are a special case HOT 1
- Support case-sensitive HTML elements
- https://phlexing.fun is not reachable HOT 2
- Converter doesn't handle non-standard HTML attributes
- Methods that take a block shouldn't be called with `plain`
- Integrate Monaco Editor
- Copy to clipboard button copies old code, not what is in text box HOT 2
- `form_with` short-circuits output HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phlexing.