GithubHelp home page GithubHelp logo

Comments (7)

mmontes11 avatar mmontes11 commented on June 9, 2024

Hey there @Guzzi ! Thanks for bringing this up.

To be compatible with kustomize imageTagTransformer either the object for image should comply to the standarf image object - or should have a different naming I suppose - what do you think?

That makes complete sense. We should align with the Pod specification to better integrate with tools like kustomize.

This will require breaking changes though, but I think it still worth it.

from mariadb-operator.

Guzzi avatar Guzzi commented on June 9, 2024

Hi @mmontes11 ,
any chance to get this change released? Without it, I am unable to integrate mdb into kustomize which collides with the current object definitions. If you hesistate to apply breaking change, you could rename the mdb objects, so they do not collide with default kubernetes object names!?

from mariadb-operator.

mmontes11 avatar mmontes11 commented on June 9, 2024

Hey there @Guzzi ! I will try to squeeze it in v0.0.21.

If you hesistate to apply breaking change, you could rename the mdb objects, so they do not collide with default kubernetes object names!?

That's actually a good suggestion, and actually the strategy followed by CNPG:

The downside I guess is that we will be losing integration with tooling like kustomize.

from mariadb-operator.

Guzzi avatar Guzzi commented on June 9, 2024

Hi @mmontes11 , not fully true - you'll not be able to use the imagetagtransformer from kustomize, but of course you always can use 'patches' to override the values - so if you want to be able to use the imagetagtransformer, you'd have to keep using the image object (name), but use the standard kubernetes object structure for images - if you rename it to something else, you won't be able to use the imagetagtransformer anymore, but avoid the compatibility issue with kustomize overlay is using the imagetagtransformer (e.g. for other manifests) and have to use a kustomize 'patch' to override e.g. the image tag for the mdb cr. I am fine with either solution - and thanks for your great support!

from mariadb-operator.

mmontes11 avatar mmontes11 commented on June 9, 2024

Hey there @Guzzi. Thanks a lot for your input, very much appreciated.

The PR for supporting the standard Kubernetes object is ready:

Could you please take a look at the migration described there to see if this is what you expect? 🙏🏻

from mariadb-operator.

Guzzi avatar Guzzi commented on June 9, 2024

Hi @mmontes11,
thanks for the update. As far as I have experienced the imagetagtransformer, it seems to only be aplied to image objects within containers/initcontainers - but yes, object type should be ok like this - looks the same like within e.g. kubernetes depployment - so I would think it should work this way.

from mariadb-operator.

mmontes11 avatar mmontes11 commented on June 9, 2024

great to hear @Guzzi , v0.0.21 has been released with this change

from mariadb-operator.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.