Comments (7)
Seems like this is a limitation of react-github-permalink as well.
Yeah exactly. I'm not a web-dev person so I realized I was making a lot of bad assumptions lol. Now I think I'll just use the extension to statically generate the HTML from markdown, and serve that for my purposes. I'm also using a forked version of zero-md since there are some style things I want from that, but the extension should be usable for anyone that wants to go from markdown to HTML, with embedded GH permalink displayed like how GH displays them in threads.
I'll publish the extension when it's polished, in case anyone ever finds it helpful.
from marked.
If you want to create an extension we can add it to our known extensions.
from marked.
Cool. I'm somewhat unfamiliar with the HTML space, but happy to give it a shot.
from marked.
Got it to work but now it feels like a bad idea, since it involves querying the GitHub API for file content every time you parse a permalink, which requires an access token, and there's a rate limit. Maybe it's better to just show the link and copy over the source code...
from marked.
Seems like this is a limitation of react-github-permalink as well.
from marked.
Here it is: https://github.com/StrongerXi/marked-gh-permalink
from marked.
Awesome! 💯
If you want to you can create a PR to add the extension to known extensions in https://github.com/markedjs/marked/blob/master/docs/USING_ADVANCED.md
from marked.
Related Issues (20)
- Block level extension not rendering correctly HOT 2
- Emphasis cannot be rendered HOT 3
- could not resolve module HOT 4
- Support unordered lists with hyphens (-) in addition to asterisks (*) HOT 1
- problem when inserting a picture HOT 1
- Ignoring elements click prop on conversion HOT 1
- [Question] lexer - a `space` betwen two lists HOT 4
- Fail to parse image tag under specific input. HOT 2
- Feature request: footnotes HOT 1
- **xx** -> strong label, There is a problem HOT 1
- Support for chunked rendering HOT 1
- Unexpected behavior when using `marked.lexer` or `new marked.Lexer` HOT 1
- marked 13: TypeError: Cannot read properties of undefined (reading 'header') at _Renderer.tablecell HOT 2
- compiled code,named # t and # e, which may cause errors in some versions of the browser. HOT 2
- Types for `this.parser` don't match notes of v13 release because `parser` is omitted HOT 3
- Incompatible/inconsistent types with `MarkedExtension` HOT 3
- Is it possible to create a custom extension using React Components (JSX)? HOT 1
- Possible bug with Renderer.link() HOT 2
- text in single ~ will be render del,but normally only text in ~~ should be render del HOT 7
- Renderer extension documentation seems incorrect? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marked.