GithubHelp home page GithubHelp logo

Comments (7)

StrongerXi avatar StrongerXi commented on June 22, 2024 1

Seems like this is a limitation of react-github-permalink as well.

Yeah exactly. I'm not a web-dev person so I realized I was making a lot of bad assumptions lol. Now I think I'll just use the extension to statically generate the HTML from markdown, and serve that for my purposes. I'm also using a forked version of zero-md since there are some style things I want from that, but the extension should be usable for anyone that wants to go from markdown to HTML, with embedded GH permalink displayed like how GH displays them in threads.

I'll publish the extension when it's polished, in case anyone ever finds it helpful.

from marked.

UziTech avatar UziTech commented on June 22, 2024

If you want to create an extension we can add it to our known extensions.

from marked.

StrongerXi avatar StrongerXi commented on June 22, 2024

Cool. I'm somewhat unfamiliar with the HTML space, but happy to give it a shot.

from marked.

StrongerXi avatar StrongerXi commented on June 22, 2024

Got it to work but now it feels like a bad idea, since it involves querying the GitHub API for file content every time you parse a permalink, which requires an access token, and there's a rate limit. Maybe it's better to just show the link and copy over the source code...

from marked.

UziTech avatar UziTech commented on June 22, 2024

Seems like this is a limitation of react-github-permalink as well.

from marked.

StrongerXi avatar StrongerXi commented on June 22, 2024

Here it is: https://github.com/StrongerXi/marked-gh-permalink

from marked.

UziTech avatar UziTech commented on June 22, 2024

Awesome! 💯

If you want to you can create a PR to add the extension to known extensions in https://github.com/markedjs/marked/blob/master/docs/USING_ADVANCED.md

from marked.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.