GithubHelp home page GithubHelp logo

metabox title and notice text should use "...{$post_type_obj->labels->singular_name}..." instead of "...Page..." about page-links-to HOT 2 CLOSED

markjaquith avatar markjaquith commented on August 19, 2024
metabox title and notice text should use "...{$post_type_obj->labels->singular_name}..." instead of "...Page..."

from page-links-to.

Comments (2)

markjaquith avatar markjaquith commented on August 19, 2024

Hmm. There are a few issues here. One, is that this sort of compound title can't be translated. You can't pass a dynamic value to a translation string, as we don't know what the value will be until runtime. And if you use a token, you'll get oddities in certain languages where the rest of the sentence will have to change based on the gender of the subject of the sentence.

Next, there is the whole thing that the name of the plugin is "Page Links To". It should be thought of in the sense of "page view" and not "WordPress post_type = 'page'. That is, a post_type of 'movie' still has a web page where it is viewed.

I tried to make a nod in favor of "this can be anything" by saying "this content is pointing to a custom URL".

from page-links-to.

pbiron avatar pbiron commented on August 19, 2024

I hadn't thought about the translation aspect.

OK, it was just a thought.

from page-links-to.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.