Comments (5)
Hey @gsi-kevincarrera, thanks for taking the time to submit this issue! I'll take a look at it when I've got the time to verify what's happening and I'll get back to you then!
from accessible-astro-starter.
Ah, I understand! Alright, I'll close this one up. Thanks!
from accessible-astro-starter.
Just figured out, maybe it is not a good idea to update the same mainMenu instance, but create another set of functions, with another event listener if needed, to manage mobile view. A feedback will be great in order to choose a path
from accessible-astro-starter.
@gsi-kevincarrera I don't know whether it matters that the ul
reference isn't updated on resize, since the menu doesn't dynamically change? If the menu would have an extra item on another page it would require a page reload and set a new reference. Or did you mean something else?
from accessible-astro-starter.
Opened this issue, due to some inconvinients, when working on the 'mobile menu traps focus' issue. But I figured out a way, as you can see in the PR, I think this issue can be closed
from accessible-astro-starter.
Related Issues (20)
- Accordion component looks weird when in use HOT 2
- i18n support HOT 2
- Sub Menu Z-Index on Desktop HOT 5
- Mobile navigation missing current page attribute HOT 1
- Support for Astro 2? HOT 2
- Active navigation menu styling and astro-i18next HOT 3
- Can't build the theme HOT 2
- Page layout appears zoomed HOT 6
- Blog post tags? HOT 1
- A simple install and run, does not work HOT 4
- Modals aren't working in demo HOT 7
- Upgrade Astro to 3.0.0 and update other devDependencies HOT 2
- Dependency issue when deploying with Netlify after upgrade to Astro 3.0 HOT 3
- Main navigation accessibility improvement HOT 2
- Add new Forms & Inputs components for basic contact page form
- Use MatchMedia API instead of resize event listener HOT 4
- astro build fails with memory allocation error HOT 3
- View Transition scroll position not restored. HOT 2
- dark mode default HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from accessible-astro-starter.