GithubHelp home page GithubHelp logo

Comments (5)

markteekman avatar markteekman commented on May 16, 2024 1

Hey @gsi-kevincarrera, thanks for taking the time to submit this issue! I'll take a look at it when I've got the time to verify what's happening and I'll get back to you then!

from accessible-astro-starter.

markteekman avatar markteekman commented on May 16, 2024 1

Ah, I understand! Alright, I'll close this one up. Thanks!

from accessible-astro-starter.

gsi-kevincarrera avatar gsi-kevincarrera commented on May 16, 2024

Just figured out, maybe it is not a good idea to update the same mainMenu instance, but create another set of functions, with another event listener if needed, to manage mobile view. A feedback will be great in order to choose a path

from accessible-astro-starter.

markteekman avatar markteekman commented on May 16, 2024

@gsi-kevincarrera I don't know whether it matters that the ul reference isn't updated on resize, since the menu doesn't dynamically change? If the menu would have an extra item on another page it would require a page reload and set a new reference. Or did you mean something else?

from accessible-astro-starter.

gsi-kevincarrera avatar gsi-kevincarrera commented on May 16, 2024

Opened this issue, due to some inconvinients, when working on the 'mobile menu traps focus' issue. But I figured out a way, as you can see in the PR, I think this issue can be closed

from accessible-astro-starter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.