Comments (16)
I think we should NOT reuse <ReferenceInput>
, because that would add too many if
s to the code, and make its API confusing. Instead, create a <ReferenceManyInput>
and a <SelectManyInput>
.
from react-admin.
We have plans to make admin-on-rest as awesome as ng-admin. No, even more.
But it will take months. We need all the help you can give.
The chip input seems OK for an array value, but for references you need autocomplete. I don't see anything of acceptable quality in material UI land, do you have other ideas?
I'm closing this one as we won't open one issue for every ng-admin feature that needs to be ported. Feel free to continue the discussion about the implementation even though the issue is closed.
from react-admin.
This chip input component actually supports autocomplete. If you go to the demo storybook and select "with auto complete, open on focus", you actually get a similar experience to what is now in ng-admin. I hope I'll find the time this week to take a closer look.
from react-admin.
Reopening this one as it'll guide us for future enhancements.
from react-admin.
Alas, I need this one also.
Guess that'll be another PR 🎉 .
from react-admin.
@fzaninotto Can I add material-ui-chip-input to aor dependencies and make PR? I'm happy to help, but I wonder what is the true way to do that kind of thing.
from react-admin.
@kimkha Yes, it's a small dependency, no problem. Could you and @leesei coordinate efforts?
from react-admin.
@kimkha I haven't started on it yet but I'll implement it before mid-April.
Are you free to start it now?
from react-admin.
I'm OK to start now, but I think it take time to start, because I'm new with AOR :)
Which function should we support? Array values, reference to many,... what's more?
from react-admin.
I suppose <ReferenceManyInput>
will bind to a array of ids to source
.
I'm not sure if we need a <SelectManyInput>
/<MultiSelectInput>
.
from react-admin.
Currently, we have <ReferenceManyField>
. I think we must separate to 2 inputs: <ReferenceManyInput>
for reference, and <ArrayInput>
for array only. Because they look like difference...
The first thing, we must handle API calling, and when user choose one, we need to insert the ID of item. But in case of second one, we just only insert the text.
from react-admin.
I change my mind. I think we should re-use <ReferenceInput>
, but its children is <ArrayInput>
. That might be easy to implement and make AOR better reusable.
from react-admin.
@fzaninotto What do you think about that idea? If yes, I need to change <ReferenceInput>
in fetchReferenceAndOptions
to add crudGetMany
...
from react-admin.
DONE. I will make PR.
from react-admin.
This should be closed, the change has been merged for a while now, no?
from react-admin.
Right, fixed in #597
from react-admin.
Related Issues (20)
- NumberInput's `onBlur` prop does not provide an event object HOT 2
- Add ability to customize query string format for lists HOT 5
- i want to show the received gmail in react js app
- AutoComplete choice listing issue when using useChoicesContext HOT 1
- react admin error with Menu.Item missing properties HOT 6
- storeKey prop is not passed to useRecordSelection hook inside useListController HOT 5
- useEditContext returns null for both values HOT 5
- Infinite loop occurs in page rendering when perPage is set to a negative number in List Component HOT 2
- Codemods are not included in ra-core v5
- Duplicate entries in documentation search HOT 2
- `<PasswordInput/>` or `<TextInput/>` has corrupted `validate` prop, if field is handled with `disabled` prop HOT 4
- Auth provider login Promise rejection with "message" doesn't trigger notification message HOT 1
- When we use useRedirect hook to go back to a List Component, the pagination is reseted to page 1
- <AutocompleteInput> and <AutocompleteInputArray> refetch choises passed from graphql HOT 1
- Fields inside the ArrayInput aren't set as dirty when built HOT 1
- When a form contains ArrayInput with large entries. It takes more than a minute for a form to be submitted. HOT 2
- Bug in Translation in post edit page showing (post "some text here") HOT 1
- Dark mode become default upgrading react-admin package HOT 1
- AutocompleteInput with ReferenceInput calling getList() two times after select on sugestion list HOT 1
- Clearing filters using setFilter({}) does not clear FilterLiveSearch text input
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-admin.