Comments (8)
For this issue, I get sometimes weird positions from the GitHub API.
I opened a thread on the GitHub Platform forum.
from sedy.
Another inefficient diff parser error
{
hunk: '@@ -44,15 +44,21 @@ Lastly, filesystems don\'t order files the same way. Some filesystems don\'t even\n \n You probably have a different configuration on the `development` environment, and on the `test` environment. This can be `ENV` vars, API endpoints, databases, browsers, etc.\n \n-One of the first things to do to reproduce a CI build locally is to use exaclty the same setup as the CI. If your build setup is good, it should be as easy as running:\n+to reproduce a CI build locally, one of the first things to do is to use exaclty the same setup as the CI. If your build automation is good, it should be as easy as running:',
position: null
}
from sedy.
Hint for the position = null
, it can be a review submitted from a commit no from the PR "files changed".
from sedy.
http://stackoverflow.com/questions/37866485/pr-review-comment-position
from sedy.
I re-open this issue since I have some new elements.
I also reverted what I thought it was the solution. #86
from sedy.
Another one marmelab/comfygure#90 (review) :
{
hunk: '@@ -24,31 +34,39 @@ const ls = (ui, modules) => function* () {\n };\n \n const add = (ui, modules, options) => function* () {\n- const { red, bold } = ui.colors;\n+ const { red, bold, green } = ui.colors;\n \n if (!options.length) {\n ui.error(`${red(\'No environment specified.\')}`);\n- help(ui, 1);\n }\n \n if (options.length > 1) {\n ui.error(`${red(\'Invalid environment format. The environment name should be one word.\')}`);\n- help(ui, 1);\n+ }\n+\n+ if (options.length !== 1) {\n+ ui.print(`${bold(\'SYNOPSIS\')}\n+ ${bold(\'comfy\')} env add <environment>\n+\n+Type ${green(\'comfy env --help\')} for details`);\n+\n+ return ui.exit(0);\n }\n \n const project = yield modules.project.retrieveFromConfig();\n const environment = yield modules.environment.add(project, options[0]);\n- const addCommand = `comfy add ${environment.name}`;\n+ const addCommand = `comfy setall ${environment.name}`;\n \n- ui.print(`${bold(\'Cool!\')} Your new environment "${bold(environment.name)}" was successfully saved.`);\n- ui.print(`You can now add a configuration, try ${bold(addCommand)}`);\n+ ui.print(`${bold(green(\'Environment successfully created\'))}`);\n+ ui.print(`You can now set a configuration fot this environment using ${bold(addCommand)}`);',
position: 71
}
from sedy.
Here is another bug: https://github.com/marmelab/admin-on-rest/pull/1521#discussion_r168098179
{
hunk: '@@ -109,6 +110,106 @@ export const PostList = (props) => (\n );\n ```\n \n+### Bulk Actions\n+\n+You can replace the list of default bulk actions by your own element using the `bulkActions` prop:',
position: 14
}
from sedy.
Here is a bug commenting this file
src/fixer.js l44
found 4 lines
debug infos { parsedContent:
{ fixes: [ [Object] ],
pullRequest: { number: 1, ref: 'refs/heads/sedy' },
repository: { name: 'sedy-test', user: 'Luwangel' },
sender: 'Luwangel' },
lines:
[ '# sedy-test',
'',
'This repository is used to test [sedy](https://github.com/marmelab/sedy).',
'' ],
index: 3,
diffHunk: '@@ -1 +1,3 @@\n-# sedy-test\n\\ No newline at end of file\n+# sedy-test\n+\n+This repository is used to test [sedy](https://github.com/marmelab/sedy).',
position: 5 }
An error occurred { name: 'TypeError',
message: 'You may only yield a function, promise, generator, array, or object, but the following object was passed: "null"',
stack: 'TypeError: You may only yield a function, promise, generator, array, or object, but the following object was passed: "null"\n at next (/home/adrien/Documents/dev/sedy/sedy/node_modules/co/index.js:101:25)\n at onFulfilled (/home/adrien/Documents/dev/sedy/sedy/node_modules/co/index.js:69:7)\n at <anonymous>\n at process._tickCallback (internal/process/next_tick.js:188:7)' }
from sedy.
Related Issues (20)
- Poorly parsed GitHub's diff HOT 1
- Improve/remove bot comment
- Refactor fixer with strategies HOT 1
- A commit has replaced all accent to a weid char `C)` HOT 3
- Global Flag / Add an option to replace every occurrence of a typo in the PR HOT 2
- Make it compatible with the new Github review system HOT 3
- If there is twice the same pattern in the diff, the parser take the first
- Idea for the logo [concept] HOT 3
- Make multiple fixes in one commit (for review comment)
- Issue when replacing ` ?` HOT 1
- My organization repositories don't show up HOT 7
- `CONTRIBUTING.md` points to a dead link in the README HOT 1
- Add push on :+1: from submitter HOT 4
- marmelab.com/sedy/setup/ just show up 30 repos HOT 1
- 404 GitHub Error with a specific command HOT 2
- GitHub Validation Failed HOT 1
- Sedy failed to detect a change HOT 1
- Edge case with quotes and/or stars? HOT 1
- Write readable E2E tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sedy.