std::search called in search() when compiling with C++14 about string-view-lite

[oliverlee]

Although I suppose it would make sense to allow a user to select std::search via a preprocessor macro (or vice-versa).

[eyalroz]

Oh, actually, maybe it's a dupe of my other bug.

[oliverlee]

You can try defining __OPTIMIZE__ before including string_view.hpp or build with optimizations enabled.

string-view-lite/include/nonstd/string_view.hpp

Lines 554 to 576 in 5b1d95f

	#if defined(__OPTIMIZE__)
	// gcc, clang provide __OPTIMIZE__
	// Expect tail call optimization to make search() non-recursive:
	template< class CharT, class Traits = std::char_traits<CharT> >
	constexpr const CharT* search( basic_string_view<CharT, Traits> haystack, basic_string_view<CharT, Traits> needle )
	{
	return haystack.starts_with( needle ) ? haystack.begin() :
	haystack.empty() ? haystack.end() : search( haystack.substr(1), needle );
	}
	#else // OPTIMIZE
	// non-recursive:
	template< class CharT, class Traits = std::char_traits<CharT> >
	constexpr const CharT* search( basic_string_view<CharT, Traits> haystack, basic_string_view<CharT, Traits> needle )
	{
	return std::search( haystack.begin(), haystack.end(), needle.begin(), needle.end() );
	}
	#endif // OPTIMIZE

https://stackoverflow.com/questions/14618249/is-there-a-builtin-macro-defined-when-optimisation-is-enabled-in-clang

[martinmoene]

@eyalroz, @oliverlee

The unconditional constexpr in the non-optimize case of constexpr const CharT* search() should perhaps be replaced with something like nssv_constexpr20_lib.

I'd like nssv_HAVE_CONSTEXPR_20_LIB to be not overly restrictive as it may be as show below. Suggestions are quite welcome.

// Presence of C++20 library features:

#define nssv_HAVE_CONSTEXPR_20_LIB  nssv_CPP20_000

// ...

#if  nssv_HAVE_CONSTEXPR_20_LIB
# define nssv_constexpr20_lib  constexpr
#else
# define nssv_constexpr20_lib  /*constexpr*/
#endif

// ...

#else // OPTIMIZE

// non-recursive:

template< class CharT, class Traits = std::char_traits<CharT> >
nssv_constexpr20_lib const CharT* search( basic_string_view<CharT, Traits> haystack, basic_string_view<CharT, Traits> needle )
{
    return std::search( haystack.begin(), haystack.end(), needle.begin(), needle.end() );
}

#endif // OPTIMIZE

[oliverlee]

I think it makes sense to remove the branch on _OPTIMIZE_. By removing the call to std::search, this would allow use in constant expressions with debug builds.

[martinmoene]

However, a possibly recursive search, possibly exhausting the stack doesn't look like the right thing to do at default.

[oliverlee]

Ah right. In that case, what about replacing the second implementation with something like:

template< class CharT, class Traits = std::char_traits<CharT> >
nssv_constexpr14 const CharT* search( basic_string_view<CharT, Traits> haystack, basic_string_view<CharT, Traits> needle )
{
    while (needle.size() <= haystack.size()) {
        if (haystack.starts_with(needle)) {
            return haystack.cbegin();
        }

        haystack = basic_string_view<CharT, Traits>{ haystack.begin() + 1, haystack.size() - 1U };
    }

    return haystack.cend();
}

[martinmoene]

@oliverlee Thanks for your suggestions!

[oliverlee]

Thanks for sharing your implementation of string view!