GithubHelp home page GithubHelp logo

Comments (4)

martinsileno avatar martinsileno commented on May 26, 2024

Hi,

thanks for the issue and the PR!

The only thing left to worry about is the removal of killPoints, killPointsDelta, winPoints and winPointsDelta from PC's participants attributes.

I think the easiest way to handle it would be to mark those fields as nullable in IParticipantAttributes (and by consequence, mark the same fields as nullable in the class Participant). This way we would keep the same code working for both PC and XBOX, otherwise we'd have to split Participant objects according to the platform requested, and I don't really like that.

Something like this: https://gist.github.com/martinsileno/e84b6daa11f1469fd7ddb5dd6e913ea9.

If you have better ideas let me know!

Anyway, since they are marked as deprecated, according to their release process they will still be available for two weeks after the release.

from pubg-typescript-api.

ThomasOrtiz avatar ThomasOrtiz commented on May 26, 2024

I like the idea of keeping one participant object instead of separating them out -- keeps the models more maintainable for now.

I took your gist and updated my PR with your changes 👍

from pubg-typescript-api.

ThomasOrtiz avatar ThomasOrtiz commented on May 26, 2024

@martinsileno PUBG made another announcement today so I updated this issue to be generically for v6.0.0 and updated notes.

from pubg-typescript-api.

martinsileno avatar martinsileno commented on May 26, 2024

PR merged and version v1.5.0 released! 🎉

Only thing left is to add typing for seasonState, as soon as we know its format.

from pubg-typescript-api.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.