GithubHelp home page GithubHelp logo

Throw stream errors about combine HOT 5 OPEN

ark0f avatar ark0f commented on July 25, 2024
Throw stream errors

from combine.

Comments (5)

Marwes avatar Marwes commented on July 25, 2024

You would return an error if the stream can no longer be used to retrieve more tokens. If you have a specific error token the I would assume that the stream may still be used, just that one token was an error so you would return Ok(Token::Error) to allow the parsing to continue (if the parser accepts, and recovers from the error token that is)

from combine.

ark0f avatar ark0f commented on July 25, 2024

I would assume that the stream may still be used

Not always. Unfinished string can break all following lexing

if the parser accepts, and recovers from the error token that is

That the only solution I found. I created my own token parser, but is it idiomatic way to handle such errors in combine?

from combine.

Marwes avatar Marwes commented on July 25, 2024

That the only solution I found. I created my own token parser, but is it idiomatic way to handle such errors in combine?

Yes, I think so at least. What would be the alternative?

from combine.

ark0f avatar ark0f commented on July 25, 2024

What would be the alternative?

Throw error from stream (maybe). It gives more guarentees that invalid input won't be skipped.

Otherwise I have to be sure that every parsing action is based on my own token parser

from combine.

Marwes avatar Marwes commented on July 25, 2024

I suppose you could instead use a parser which inspects the error being returned and recovers if you deem it to be a recoverable error

from combine.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.