Comments (3)
Oh, I forgot a wrinkle: we want std::error::Error
so that we can use https://github.com/brson/error-chain. However, error-chain
doesn't support error types that contain references and lifetimes (although I can't find the issue where I learned this right now). That means it might not be enough to solve this problem for us; we might need additional support for converting range types to owned types in errors.
Maybe what I want is to require ToOwned
when constructing the Info
objects in errors? It looks like one type can have multiple ToOwned
implementations, so this still might not be specific enough.
from combine.
That means it might not be enough to solve this problem for us; we might need additional support for converting range types to owned types in errors.
This I think is the first problem we should solve. For the errors actually created by the parser I don't see any way around the the errors having lifetimes in them. I think the best way to work around that is to make it easy to transform a ParseError
with lifetimes into one without them. If ParseError
were defined as a type with three parameters (ParsError<Position, Item, Range>
) instead of the current which only takes Input https://docs.rs/combine/2.2.2/combine/struct.ParseError.html, then it would be possible to provide a map function.
fn map(self, f: impl FnMut(Position) -> Position2, g: impl FnMut(Item) -> Item2, h: impl FnMut(Range) -> Range2) -> ParseError<Position2, Item2, Range2>
I always wanted to this change but I have held out waiting for rust-lang/rust#21903. If that issue were fixed it should be possible to do
type ParseError<S: StreamOnce> = ParseErrorEx<S::Position, S::Item, S::Range>;
struct ParseErrorEx<P, I, R> { .. }
from combine.
Ah, interesting, that would be nice. I didn't want to generalize ParseError
into having three types because it churns a lot of combine
, and it churns external consumers.
Locally, I have elected to post-process ParseError<&'a [T]>
into a simpler error with owned ranges. To do that, I implemented a map
-like function map_err_range
for ParseError
, Error
, and Info
. I'll post a patch, since it could live in combine
; but I think everything's pub
, so this mapping could happen in our consuming code as well.
from combine.
Related Issues (20)
- Is there a way to get `Stream<Token=char>` from `io::Read`? HOT 1
- Tools for debugging recursion problems? HOT 4
- Some issue with error reporting
- Errors include unprintable or awkwardly printed characters. HOT 6
- `expected` error strings always quote what was expected, even if it isn't a literal HOT 3
- How about offset into some data? HOT 3
- Outdated tutorial HOT 1
- Native/abstracted sub-parsers HOT 6
- XML parsing for React.js to Solid.js conversion HOT 4
- Comparison with LALRPOP
- Unbounded mutual recursion in Parser impl HOT 3
- Adivce on reducing code size in WASM target HOT 7
- Docs unclear whether `parser!` should be used on nightly rust HOT 2
- Parse `std::process::Child` stdout
- Successful parser will not clear the error stack HOT 1
- build failure
- Implement Pratt parsing or precedence climbing HOT 4
- Choice with Vec of parsers HOT 4
- Documentation request: no_partial
- Worse performance after parsing 2 large values HOT 9
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from combine.