Images in notifications overflow about mastodon-android

[grishka]

The problem was actually related to screen rotation and the changing size of the list caused by that.

[grishka]

These inset images are such a pain tbh

I can't reproduce this tho.

[brawaru]

Have you tried with that exact image? Also, I wonder if it matters that it's a reply.

[grishka]

¯\_(ツ)_/¯

(pixel 4a, stock android 11)

[brawaru]

Also, I wonder if it matters that it's a reply.

?

[grishka]

Nope, just tested that

[brawaru]

Makes me wonder. What happens if it is a reply and has new lines in the post (like I have two mentions separated by new line)?

[realpixelcode]

Though, I think images shouldn't be displayed in the notifications because they take up so much space that shouldn't be wasted just for the information that someone has favourited or boosted your toot. If you still want to see the entire toot, you can just open it separately by clicking on it.

Maybe, also the text of toots in the notifications could be collapsed 🤔

[grishka]

Makes me wonder. What happens if it is a reply and has new lines in the post (like I have two mentions separated by new line)?

These things shouldn't influence each other. Posts (and notifications) are rendered as a series of "display items", as I call them. A block of text is a display item, each image is a display item, and the "in reply to", you'll never guess, is also a display item. This is how the scrolling is so smooth. The list uses a GridLayoutManager, but all items except images and videos occupy all spans. So no, separate items shouldn't be able to affect each other.

The insets for notifications are done with this code I'm really not proud of:

mastodon-android/mastodon/src/main/java/org/joinmastodon/android/fragments/NotificationsListFragment.java

Lines 211 to 245 in 2e1f08a

	public void getItemOffsets(@NonNull Rect outRect, @NonNull View view, @NonNull RecyclerView parent, @NonNull RecyclerView.State state){
	RecyclerView.ViewHolder holder=parent.getChildViewHolder(view);
	if(holder instanceof StatusDisplayItem.Holder<?> sdi){
	boolean inset=sdi.getItem().inset;
	int pos=holder.getAbsoluteAdapterPosition();
	if(inset){
	boolean topSiblingInset=pos>0 && displayItems.get(pos-1).inset;
	boolean bottomSiblingInset=pos<displayItems.size()-1 && displayItems.get(pos+1).inset;
	int pad;
	if(holder instanceof ImageStatusDisplayItem.Holder || holder instanceof LinkCardStatusDisplayItem.Holder)
	pad=V.dp(16);
	else
	pad=V.dp(12);
	boolean insetLeft=true, insetRight=true;
	if(holder instanceof ImageStatusDisplayItem.Holder<?> img){
	PhotoLayoutHelper.TiledLayoutResult layout=img.getItem().tiledLayout;
	PhotoLayoutHelper.TiledLayoutResult.Tile tile=img.getItem().thisTile;
	// only inset those items that are on the edges of the layout
	insetLeft=tile.startCol==0;
	insetRight=tile.startCol+tile.colSpan==layout.columnSizes.length;
	// inset all items in the bottom row
	if(tile.startRow+tile.rowSpan==layout.rowSizes.length)
	bottomSiblingInset=false;
	}
	if(insetLeft)
	outRect.left=pad;
	if(insetRight)
	outRect.right=pad;
	if(!topSiblingInset)
	outRect.top=pad;
	if(!bottomSiblingInset)
	outRect.bottom=pad;
	}
	}
	}

[sk22]

Do you still have this issue as well, @brawaru? Because I unfortunately do…