Comments (2)
@matanshukry : you can now close this one after 0.3.7
from flutter_google_places_sdk.
I've investigated this and the problem is that some filters are more complicated than just lowercasing it.
For example : CITIES should be converted to either (cities)
, locality
or administrative_area_level_3
Prior to the latest update the google sdks were expecting an enum value for the PlaceTypeFilter but now it requires a list of strings.
Current version of this SDK sends the enum values from the dart code to each platform and each platform has the responsibility to convert it to a String.
Some platform codes was doing things right (for example the web platform was converting the filters to their correct values), but other platforms were not (android is just lowercasing it).
I think we should convert it to a list of string on the Dart side, and then send the list to each platform.
each platform will only have to forward this list to its own SDK.
I've written the code, but I cannot figure out how to test it locally because each package depends on published versions and my fix changes many packages.
My patch should fix this bug, but also #48 and #57
I just need to test it before I can submit the PR
@matanshukry : is there a way to test changes locally, without publishing the packages or changing all the pubspecs of each platform ?
from flutter_google_places_sdk.
Related Issues (20)
- [BUG] PlusCode can be null HOT 1
- Flutter web deploy issue on aws HOT 1
- Places API (new) HOT 4
- Android: API_ERROR_AUTOCOMPLETE, 9011: This IP, site or mobile application is not authorized to use this API key. HOT 1
- [flutter_google_places_sdk_ios] 0.1.3 contains a breaking change. It should have be versioned as 0.2.0 HOT 4
- Searching for CITIES and ADDRESS in the same placeTypeFilter array returns no results. HOT 1
- error launching on IOS simulator linking in object file HOT 1
- Support JDK 17 HOT 6
- Web release only : crash using findAutocompletePredictions method HOT 3
- InvalidValueError if using findAutocompletePredictions with origin HOT 2
- _places.fetchPlace has work on web debug and not work in release web HOT 2
- Upgrade Google Maps dependency HOT 2
- Google Maps JavaScript API has been loaded directly without loading=async HOT 1
- Add support for Google Places (new) HOT 2
- web package could use a version bump HOT 1
- Dependencies issues after upgrading to google_maps_flutter 2.6.1 HOT 2
- Support for js ^0.7.1 HOT 1
- Add Support for Google Places (New) HOT 2
- Same place but different results between OS (Android & IOS) HOT 4
- version solving failed. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flutter_google_places_sdk.