GithubHelp home page GithubHelp logo

Comments (2)

maxbritto avatar maxbritto commented on August 14, 2024 1

@matanshukry : you can now close this one after 0.3.7

from flutter_google_places_sdk.

maxbritto avatar maxbritto commented on August 14, 2024

I've investigated this and the problem is that some filters are more complicated than just lowercasing it.
For example : CITIES should be converted to either (cities) , locality or administrative_area_level_3

Prior to the latest update the google sdks were expecting an enum value for the PlaceTypeFilter but now it requires a list of strings.

Current version of this SDK sends the enum values from the dart code to each platform and each platform has the responsibility to convert it to a String.

Some platform codes was doing things right (for example the web platform was converting the filters to their correct values), but other platforms were not (android is just lowercasing it).

I think we should convert it to a list of string on the Dart side, and then send the list to each platform.
each platform will only have to forward this list to its own SDK.

I've written the code, but I cannot figure out how to test it locally because each package depends on published versions and my fix changes many packages.

My patch should fix this bug, but also #48 and #57
I just need to test it before I can submit the PR

@matanshukry : is there a way to test changes locally, without publishing the packages or changing all the pubspecs of each platform ?

from flutter_google_places_sdk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.