GithubHelp home page GithubHelp logo

Comments (9)

Snuggle avatar Snuggle commented on August 23, 2024

Interesting, two quick-questions to start:

Where does the Pure prompt implement this text wrapping? How many other terminal prompts wrap in a similar fashion?

from spacefish.

smorimoto avatar smorimoto commented on August 23, 2024

Hi! Hmm... I really don't familiar with fish shell, so I couldn't find. and I've not checked other themes except Pure, but I can check the other ones when I have much time.

from spacefish.

Snuggle avatar Snuggle commented on August 23, 2024

image

Is this what you're referring to?

from spacefish.

Snuggle avatar Snuggle commented on August 23, 2024

Hm, I can reproduce & this causes some incredibly weird behaviour. Typing exit exits the terminal emulator. I've seen this a couple of times before, but didn't know what caused it.

This completely breaks the prompt and I can't find a way to resolve it without reopening a new terminal instance.

image
image

from spacefish.

matchai avatar matchai commented on August 23, 2024

This is actually deliberate behavior in fish: fish-shell/fish-shell#904 (comment)
There has been a proposal in a past issue to identify when text wraps and to dynamically shorten or split the prompt based on the width of the terminal. I'd consider it if that's what zsh does natively.

from spacefish.

Snuggle avatar Snuggle commented on August 23, 2024

It completely breaks the fish instance though? Commands like ls stop working entirely afterwards?

from spacefish.

matchai avatar matchai commented on August 23, 2024

Oof. Yeah, didn't expect that to happen. 😰
Unfortunately, this still appears to be an upstream issue, being able to reproduce it without spacefish installed:
image

from spacefish.

Snuggle avatar Snuggle commented on August 23, 2024

Is there a workaround we could make to get around this issue? I've had it myself a few times and just ended up opening a new terminal instance instead.

from spacefish.

matchai avatar matchai commented on August 23, 2024

I think anything we end up doing here would be hacky and this would best be addressed by the fish team, unless we decide to make the theme dynamically resizing based on $COLUMNS.

Closing this as it's not an issue in spacefish, but feel free to keep the conversation going. 😄

from spacefish.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.