Comments (5)
Thank you Gwendal for your comment.
I just want Subify to take up the KISS principle. I think we should have only a video as an input parameter. I'd prefer parsing the video name or use the API of OpenSubtitles to get information (season, episode, etc.) about the video from the hash. Then create our own API for Addic7ed with this kind of information as an input.
What do you think ?
from subify.
I agree with you but we need to define some pattern to parse correctly the input video. So there is some points to discuss :
- How to determine if the input video is a film or a tv show ?
- According to the web conventions seasons and episodes should be parse using a pattern like this
/.?(\d{1,2}).?(\d{1,2}).*?/g with \1 as seasons et \2 as episodes - How to determine which version to choose (there is many versions on addic7ed and there is no ranking system)
- I found an api in js here : https://github.com/same31/addic7ed-api
from subify.
- Maybe with OpenSubtitles API. We could get information from the hash of the video. Actually we don't really care because we could use the search function of Addic7ed. I tried "Shameless.US.S06E04.720p.HDTV.X264-DIMENSION" in their main page and I was redirected to the right page. With a film name, I don't get redirected to the page, but it displays a page of results.
- Many patterns could be used indeed. But the simplest is using the search function of Addic7ed.
- No rank needed, we "just" have to found the right subtitle from the Team that edited the video (It's in the page). To extract this information, I created in 2 minutes an API with import.io It could work well with a little tuning : https://api.import.io/store/connector/20268375-825f-44e7-bbe6-4b04d8a36145/_query?input=webpage/url:http%3A%2F%2Fwww.addic7ed.com%2Fserie%2FShameless_%2528US%2529%2F6%2F4%2FGoing_Once%252C_Going_Twice&&_apikey=91b43c5e88094addbd5dd95d619139a88556fdfbaf3b1998f011d2973d4fc363b3805f7d5d3cd1f908fc0dcabd5159fc5f4724feda33dc243209a6233feb571aa2e988822aed743e335be6d7ac4e3e2f
Other is solution is to search in the DOM like the JS API you found. - Could be a start.
Keep in mind that aim is to give the best suitable subtitle, transparently by using several APIs. It really is a "best effort mode". If Subify can't parse for Addic7ed or don't find exactly the right subtitle, don't worry it will probably succeed in downloading from OpenSubtitles or SubDB.
from subify.
Bumping an old issue, but the Subtitleseeker API could be used just by providing a release title (filename).
from subify.
@gwleclerc @Lomanic New version is out with Addic7ed support :)
from subify.
Related Issues (12)
- Subify logging uses fmt instead of log
- Add the language to the file name
- Disable notifications in MacOS HOT 1
- ARM build HOT 3
- OpenSubtitles may not work anymore
- Remove language suffix from subtitle name.
- Option to list if st are there
- Error reaching addic7ed
- Partial uploaded vendor fails the build HOT 1
- go get -u failed HOT 5
- Adding Subify in the Windows Context menu HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from subify.