GithubHelp home page GithubHelp logo

Comments (5)

matcornic avatar matcornic commented on June 3, 2024

Thank you Gwendal for your comment.
I just want Subify to take up the KISS principle. I think we should have only a video as an input parameter. I'd prefer parsing the video name or use the API of OpenSubtitles to get information (season, episode, etc.) about the video from the hash. Then create our own API for Addic7ed with this kind of information as an input.

What do you think ?

from subify.

gwleclerc avatar gwleclerc commented on June 3, 2024

I agree with you but we need to define some pattern to parse correctly the input video. So there is some points to discuss :

  • How to determine if the input video is a film or a tv show ?
  • According to the web conventions seasons and episodes should be parse using a pattern like this
    /.?(\d{1,2}).?(\d{1,2}).*?/g with \1 as seasons et \2 as episodes
  • How to determine which version to choose (there is many versions on addic7ed and there is no ranking system)
  • I found an api in js here : https://github.com/same31/addic7ed-api

from subify.

matcornic avatar matcornic commented on June 3, 2024

Keep in mind that aim is to give the best suitable subtitle, transparently by using several APIs. It really is a "best effort mode". If Subify can't parse for Addic7ed or don't find exactly the right subtitle, don't worry it will probably succeed in downloading from OpenSubtitles or SubDB.

from subify.

Lomanic avatar Lomanic commented on June 3, 2024

Bumping an old issue, but the Subtitleseeker API could be used just by providing a release title (filename).

from subify.

matcornic avatar matcornic commented on June 3, 2024

@gwleclerc @Lomanic New version is out with Addic7ed support :)

from subify.

Related Issues (12)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.