GithubHelp home page GithubHelp logo

Comments (5)

LoganTann avatar LoganTann commented on July 26, 2024 1

Then shouldn't we fix this for v2 instead of v1.1 ?

I think it's not a priority issue (sorry for this thread to take so long, but the lack of contributors make hard to focus on every single issue here)

from materialize.

DanielRuf avatar DanielRuf commented on July 26, 2024

That sounds good. A PR is very welcome.

from materialize.

schorsch avatar schorsch commented on July 26, 2024

Btw. i tried to get rid of those in another piece of code just a week ago and after three hours left them in place.

Why?

  • they are still supported across browsers
  • there seems to be no prio, browser-wise, to kick those
  • the alternatives are very verbose and not aligned cross-browser

just my 2 cents as i stumbled upon this fork today. Great to see some movement and i commented bcs. i think there are other parts which require more attention/man-power.

from materialize.

DanielRuf avatar DanielRuf commented on July 26, 2024

you should use KeyboardEvent.key instead, if available.

from materialize.

mauromascarenhas avatar mauromascarenhas commented on July 26, 2024

Closing this issue, since it has already been fixed on fea501a 😄.

from materialize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.