GithubHelp home page GithubHelp logo

Comments (8)

tomwjerry avatar tomwjerry commented on July 26, 2024 2

I have ported all the tests from jQuery (quite a bit of change) to vanilla js based on @samschurter code. I don't want to steal his work but I based my work on his repo since some tests has been added and he did some changes to use a local server for testing. sam should probably answer on this but in order to make things going I can provide a PR after waiting a little. Since there are many changes it is going to take some time to review.

Actually, while waiting I will try to make some modifications and remove the additional tests. First step is to port and update testing framework. Second step is to add the new tests.

from materialize.

Smankusors avatar Smankusors commented on July 26, 2024

hmm... if we do upgrade to the chrome headless, it's included when doing npm install, or we need to install it manually?

from materialize.

samschurter avatar samschurter commented on July 26, 2024

Good question, I for one definitely want it to be as seamless as possible. It uses headless chrome via the puppeteer project, which downloads a version of chromium guaranteed to work with puppeteer. I branched an upgraded just grunt-contrib-jasmine and it installed chrome and started up just fine, but the tests all fail because jasmine-jquery can't load the fixtures due to a CORS issue.

from materialize.

samschurter avatar samschurter commented on July 26, 2024

I added a task to the grunt file to start a server for the fixtures and it's working.

from materialize.

samschurter avatar samschurter commented on July 26, 2024

Upgrading to Jasmine 3.6 randomly breaks some tests (FAB, and Toast I have run into so far). 3.6 defaults to running tests in random order and turning random order off makes all the tests pass. So there's some tests in there that are dependent on order and need to be fixed, otherwise the upgrade from grunt-contrib-jasmine 1.2 -> 2.2 and jasmine 2.6 -> 3.6 is pretty easy.

Next I'm looking at replacing the jasmine-jquery functionality and probably stripping out all jQuery. Materialize isn't supposed to depend on jQuery anymore but there have been reports of things only working with jQuery. As long as the test suite is loading jQuery I don't see a way to make sure the components work without it.

from materialize.

DanielRuf avatar DanielRuf commented on July 26, 2024

Can you provide a (draft) PR so we can discuss the best route / solutions?

from materialize.

samschurter avatar samschurter commented on July 26, 2024

Thanks! That sounds great. I haven't abandoned this, just been really busy keeping up with projects to pay the bills.

from materialize.

samschurter avatar samschurter commented on July 26, 2024

If you want to submit the PR, please feel free. I'd rather see things move forward than wait on me.

from materialize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.