GithubHelp home page GithubHelp logo

Comments (9)

LoganTann avatar LoganTann commented on July 26, 2024 1

fixed in #213

from materialize.

bugy avatar bugy commented on July 26, 2024

@DanielRuf would such change make sense?
To be honest I don't know who is responsible now for making decisions on the direction of project development

from materialize.

DanielRuf avatar DanielRuf commented on July 26, 2024

@materializecss/members

from materialize.

Pierstoval avatar Pierstoval commented on July 26, 2024

I think this might be overkill to introduce new shades for every usage of color functions, but I agree that this might be a good solution.

I feel like this is somehow automatically feasible as long as we keep only 5 lightening and 5 darkening shades for every color.
However, this might bloat the final code a bit more...

from materialize.

doughballs avatar doughballs commented on July 26, 2024

I’m not sure how helpful I can be with regards to colours as my preference would be to remove them altogether! No project needs access to so many colours. I actually strip out all but the base colours in my projects, and even that is bloated. In truth? We receive briefs that will choose colours outside of the ones provided my materialize, and so for some they will always be redundant.

As for removing colour functions from style, I don’t know about the knock on effects but I think I’m in favour!

from materialize.

Pierstoval avatar Pierstoval commented on July 26, 2024

@doughballs I just made a suggestion on #54 about removing colors πŸ˜‰

from materialize.

doughballs avatar doughballs commented on July 26, 2024

@doughballs I just made a suggestion on #54 about removing colors πŸ˜‰

Haha great minds!

from materialize.

bugy avatar bugy commented on July 26, 2024

Thanks for the quick response:

I run a regex match for color functions in scss folder, and these are results:

_buttons.scss:60:    background-color: darken($button-raised-background, 10%);
forms/_switches.scss:60:    background-color: transparentize($switch-bg-color, .85);
forms/_switches.scss:73:  background-color: transparentize($switch-bg-color, .85);
forms/_range.scss:98:  box-shadow: 0 0 0 10px rgba($radio-fill-color, .26);
forms/_range.scss:129:  box-shadow: 0 0 0 10px rgba($radio-fill-color, .26);
forms/_range.scss:160:  box-shadow: 0 0 0 10px rgba($radio-fill-color, .26);
_tabs.scss:50:        background-color: transparentize($tabs-underline-color, .8);
_tabs.scss:60:      color: rgba($tabs-text-color, .7);
_tabs.scss:73:      color: rgba($tabs-text-color, .4);
_sidenav.scss:62:    &.btn-large:hover { background-color: lighten($button-raised-background, 5%); }
_timepicker.scss:103:	background-color: transparentize($secondary-color, .75);
_dropdown.scss:71:    background-color: darken($dropdown-hover-bg-color, 8%);
_global.scss:650:    background-color: lighten($progress-bar-color, 40%);

May be as a quick solution (because #54 will take some time, especially due to potential regression issues), we can refactor only these colors?

from materialize.

bugy avatar bugy commented on July 26, 2024

Hi @doughballs @Pierstoval I created a PR (#55). If you would have time for review and discussion, it would be awesome

from materialize.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.