GithubHelp home page GithubHelp logo

Comments (6)

dmos62 avatar dmos62 commented on August 17, 2024

Notably, this goes against the filters product concept document where it says:

The order than you apply filters in does not matter. Since filters only look at the data in a single row, you can apply them in any order and end up with the same result.

from mathesar-wiki.

silentninja avatar silentninja commented on August 17, 2024

The order than you apply filters in does not matter. Since filters only look at the data in a single row, you can apply them in any order and end up with the same result.

I think it is pointing to the filter condition(id = 1) and not the operator that joins them. Based on what @pavish has commented on the matrix there can be only one joining operator for the whole filter set

from mathesar-wiki.

kgodey avatar kgodey commented on August 17, 2024

I think it is pointing to the filter condition(id = 1) and not the operator that joins them. Based on what @pavish has commented on the matrix there can be only one joining operator for the whole filter set

Yes, this is correct. What I meant was that if you have the same filters with the same operators applied, the order doesn't matter, i.e. filters are commutative.


@silentninja Where is the filter spec documentation that needs to be updated for this issue?

from mathesar-wiki.

kgodey avatar kgodey commented on August 17, 2024

I wrote up an architecture wiki page for filters, let's keep this updated. I haven't added anything about lexical precedence yet.

from mathesar-wiki.

pavish avatar pavish commented on August 17, 2024

If the filter API supports nested filters (which was decided) in a similar format to sqlalchemy-filters, we wouldn't have a scenario with multiple operators.

Do we need to document lexical precedence?

from mathesar-wiki.

kgodey avatar kgodey commented on August 17, 2024

Do we need to document lexical precedence?

I don't think so. I'll close this issue for now, we can reopen if needed.

from mathesar-wiki.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.