GithubHelp home page GithubHelp logo

Comments (2)

mathiasbynens avatar mathiasbynens commented on June 29, 2024

That would still not work when escapeEverything: true is used, as it would escape characters with special meaning, such as [] etc. We could make it so that the regex.source is stringEscaped with escapeEverything: false at all times, though.

from jsesc.

mathiasbynens avatar mathiasbynens commented on June 29, 2024

Currently escaping regular expressions works as expected, as long as the original regular expression wasn’t constructed using escape sequences.

E.g. when regex is /\xA9/, regex.source is '\\xA9'. Running that through stringEscape() adds another layer of escaping, which leads to incorrect results.

We could do something like https://github.com/mathiasbynens/mothereff.in/blob/880f773b51200fc901d9159ad5fa369d440b6cae/js-escapes/eff.js#L50-L57 but perhaps it’s just not worth it.

from jsesc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.