GithubHelp home page GithubHelp logo

Comments (8)

cuda avatar cuda commented on June 14, 2024

That might work well. Put a static constructor in the Control class to check for the variable. If it doesn't exist, then use the managed provider. Users could still override it in their code. It would simplify testing nicely without using an NUnit extension.

from mathnet-numerics-native.

tibel avatar tibel commented on June 14, 2024

I would prefer to have the environment variable only in the tests.

If it is in Control class, someone can break my Application by changing a users environment variable. The application would become vulnerable.

from mathnet-numerics-native.

cuda avatar cuda commented on June 14, 2024

I disagree. Setting environment variables is an acceptable, standard way to control application behavior.

from mathnet-numerics-native.

cuda avatar cuda commented on June 14, 2024

and to add, an application could always use an app.config file and corresponding code to override the environment variable.

from mathnet-numerics-native.

tibel avatar tibel commented on June 14, 2024

Didn't thought on this. You are right. Should not be a problem.

from mathnet-numerics-native.

cdrnet avatar cdrnet commented on June 14, 2024

Great, thanks for the feedback!

from mathnet-numerics-native.

cdrnet avatar cdrnet commented on June 14, 2024

@cuda using environment variables, you no longer need the unit test config file (and corresponding code) then and I can drop it, correct?

from mathnet-numerics-native.

cuda avatar cuda commented on June 14, 2024

Right. We can also drop the mkl wrapper test project from the native wrapper project.

from mathnet-numerics-native.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.