Comments (2)
@richvdh This issue talks about /_matrix/identity/v2/store-invite
, whereas matrix-org/matrix-spec#495 is talking about /_matrix/identity/api/v1/store-invite
(v1
vs. v2
). From the description of #495, it sounds like the public_key
field should not have existed in either API?
public_key
is redundant. ... It should be removed.
This is currently referenced by the following projects:
/_matrix/identity/v2/store-invite
- turt2live/matrix-bot-sdk: https://github.com/turt2live/matrix-bot-sdk/blob/d4612dbb848c8a6af92fae207178e9cf15e9c92e/src/models/IdentityServerModels.ts#L16
- matrix-org/sytest: https://github.com/matrix-org/sytest/blob/3c26f28b44922f6c1248bc37924604f2a077afd7/lib/SyTest/Identity/Server.pm#L485
- matrix-org/synapse (as a fallback, if it exists): https://github.com/matrix-org/synapse/blob/4de271a7fcde6b46611ba2aa9d45cdc6cc7275ab/synapse/handlers/identity.py#L767
/_matrix/identity/api/v1/store-invite
- matrix-org/sytest: https://github.com/matrix-org/sytest/blob/3c26f28b44922f6c1248bc37924604f2a077afd7/lib/SyTest/Identity/Server.pm#L485
- matrix-org/dendrite: https://github.com/matrix-org/dendrite/blob/9b98e5a10282dbf594f46a41baa21191b2d2b8f6/clientapi/threepid/invites.go#L60 (also, the docstring of
idServerStoreInviteResponse
is a copy/paste error)
Hits in for public_key
field did not appear in the following projects, but were checked explicitly: matrix-rust-sdk, matrix-ios-sdk, matrix-android-sdk2, Ruma, famedlysdk (Matrix Dart SDK), ma1sd, Construct and Complement.
from sydent.
@richvdh This issue talks about
/_matrix/identity/v2/store-invite
, whereas matrix-org/matrix-spec#495 is talking about/_matrix/identity/api/v1/store-invite
(v1
vs.v2
).
I don't think matrix-org/matrix-spec#495 is specific to v1 or v2: it predates the existence of v2 (which was added in matrix-org/matrix-spec-proposals#2255), but the same error was carried over to the v2 spec.
Note also that matrix-org/matrix-spec#495 is talking about the format of public_keys
rather than the top-level public_key
.
From the description of #495, it sounds like the
public_key
field should not have existed in either API?
I agree that public_key
should not have existed in either API. When I opened this issue, I only mentioned v2 because v1 shouldn't exist at all (#338).
public_key
is redundant. ... It should be removed.This is currently referenced by the following projects:
/_matrix/identity/v2/store-invite
It's referenced in the model, but that doesn't necessarily mean the project is actually using it.
I'm also a bit surprised that a bot SDK needs to reference this. Per the ASCII art at https://spec.matrix.org/v1.6/client-server-api/#server-behaviour-7, it should be up to the homeserver to make this request.
Yup, looks like that line needs removing too, to make sytest return spec-compliant responses.
- matrix-org/synapse (as a fallback, if it exists): https://github.com/matrix-org/synapse/blob/4de271a7fcde6b46611ba2aa9d45cdc6cc7275ab/synapse/handlers/identity.py#L767
See matrix-org/synapse#6036. We should remove it.
/_matrix/identity/api/v1/store-invite
As above, needs a fix.
- matrix-org/dendrite: https://github.com/matrix-org/dendrite/blob/9b98e5a10282dbf594f46a41baa21191b2d2b8f6/clientapi/threepid/invites.go#L60 (also, the docstring of
idServerStoreInviteResponse
is a copy/paste error)
Again, hard to tell if this means it's actually used. I'd hope that fixing sytest would confirm one way or the other.
Thanks for doing all this research!
from sydent.
Related Issues (20)
- Is 2.5.2 the latest version of Sydent? HOT 2
- A bug in third party invitations HOT 3
- Documentation of Config File HOT 1
- Back-off retries for requests to `/3pid/onbind` against homeservers after a successful bind are not tested
- Homeserver url issue HOT 7
- [docker] Bad working directory HOT 1
- prometheus-client is required to start sydent HOT 1
- [Question] Connect with homeserver HOT 4
- Allow restricting Sydent to use by a specific list of Homeservers
- Allow turning off of terms for Sydent restricted to one homeserver HOT 3
- [docker] Permission denied: '/home/sydent/src/requirements.txt' HOT 5
- cargo/rust permission denied HOT 2
- Is there a detailed explanation of the configuration file, please? HOT 1
- LDAP search support HOT 1
- MatrixError: [502] Third party certificate could not be checked HOT 8
- `poetry install` failing on Python 3.12 HOT 2
- Inverted logic in configuration merge HOT 3
- Matrix homeserver did not include 'sub' in its response HOT 2
- Unable to contact the Matrix homeserver (ResponseNeverReceived) register 500 error HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sydent.