GithubHelp home page GithubHelp logo

Comments (3)

MattCotterellNZ avatar MattCotterellNZ commented on June 29, 2024

Makes sense. We still need to keep the non-async method there since we need to override the SignatureProvider's Sign() method, but there shouldn't be any harm in adding an additional SignAsync() (and VerifyAsync()) method too. Does that sound right?

from identityserver.contrib.azurekeyvaulttokensigningservice.

omerlh avatar omerlh commented on June 29, 2024

I don't see the benefit of using this interface, it might be better to create a dedicate interface for that...

from identityserver.contrib.azurekeyvaulttokensigningservice.

MattCotterellNZ avatar MattCotterellNZ commented on June 29, 2024

I think this was partly to provide support for people who may not be using IdentityServer but still want to use parts of this library to sign JWTs using Azure Key Vault, but this is probably misguided and should probably be well out of scope (or in a different NuGet package altogether). I'll keep this in mind before release and look into it in a bit more depth, it may be appropriate to break away from this interface.

from identityserver.contrib.azurekeyvaulttokensigningservice.

Related Issues (16)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.