Comments (3)
Makes sense. We still need to keep the non-async method there since we need to override the SignatureProvider
's Sign()
method, but there shouldn't be any harm in adding an additional SignAsync()
(and VerifyAsync()
) method too. Does that sound right?
from identityserver.contrib.azurekeyvaulttokensigningservice.
I don't see the benefit of using this interface, it might be better to create a dedicate interface for that...
from identityserver.contrib.azurekeyvaulttokensigningservice.
I think this was partly to provide support for people who may not be using IdentityServer but still want to use parts of this library to sign JWTs using Azure Key Vault, but this is probably misguided and should probably be well out of scope (or in a different NuGet package altogether). I'll keep this in mind before release and look into it in a bit more depth, it may be appropriate to break away from this interface.
from identityserver.contrib.azurekeyvaulttokensigningservice.
Related Issues (16)
- Rename project to match conventions
- Deduplicate code between IS3/IS4 flavours with a "common" library HOT 1
- Support multiple JWKs HOT 1
- Better exception message if IPublicKeyProvider cannot provide a key
- Create some example websites
- Support .NET Standard 1.6 HOT 8
- Add support for a Secondary (fallback) Key Vault
- Add support for a fallback Azure AD secret key
- Write a proper README.md
- Tidy up usage of AzureKeyVaultSignatureProvider in AzureKeyVaultTokenSigningService
- Think about how to properly cache the public key HOT 5
- AzureKeyVaultSignatureProvider.Verify() should be performed locally by default HOT 1
- Create Unit Tests
- Implement ISigningKeyService HOT 10
- Support .net 4.5/C# 5 HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from identityserver.contrib.azurekeyvaulttokensigningservice.