GithubHelp home page GithubHelp logo

Comments (6)

airwin avatar airwin commented on May 30, 2024

agree

from isomorphic-fetch.

tracker1 avatar tracker1 commented on May 30, 2024

+1 it may be better to publish what-wg fetch client as a separate module in npm, then reference/update against that?

from isomorphic-fetch.

matthew-andrews avatar matthew-andrews commented on May 30, 2024

We switched to that branch to get some basic IE9 cors support (did make a PR for this back to the GitHub polyfill — which wasn't accepted)… plan is to eliminate our need for this which I think is imminent…… (@whererhys do you know if we still IE9?)……

@tracker1 think it's already in npm registry?

from isomorphic-fetch.

tracker1 avatar tracker1 commented on May 30, 2024

Would probably just refer people to xdomain if you need to support older versions of IE... I didn't know if that specific branch (with IE9 support) was published as a separate module from the github shim.

from isomorphic-fetch.

aintgoin2goa avatar aintgoin2goa commented on May 30, 2024

This branch doesn't actually work in any browser if you need CORS with cookies. this line:

https://github.com/matthew-andrews/fetch/blob/master/fetch.js#L246

option should actually be 'include':
https://developer.mozilla.org/en-US/docs/Web/API/Request/credentials

This is a simple fix but there is quite a log of different between githubs fetch and this one, it might be a better idea to refactor out the IE9 stuff into a seperate module or something?

from isomorphic-fetch.

matthew-andrews avatar matthew-andrews commented on May 30, 2024

using the main polyfill as of v2.1.0

from isomorphic-fetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.