GithubHelp home page GithubHelp logo

Comments (6)

thessem avatar thessem commented on May 31, 2024 6

@matthew-andrews would it be possible to take another look at this? I'm on react native and I'm using some libraries that pull in this one as a dependancy, I've had to shrinkwrap them so that they use #80 instead.

I understand it's unfair to expect you to support other people using your library badly, so I have no real expectations here, I just wanted to point out that perhaps the use case is slightly less obscure than you thought.

from isomorphic-fetch.

thessem avatar thessem commented on May 31, 2024 2

@sosaucily Shrinkwrap the dependancy... read up on shrinkwrapping in npm, but the short version is you change the dependancy of redux-api-middleware in its package.json to point to #80 instead of this npm package (read up on using github branches as dependancies if you're not sure of the syntax), run npm install then npm shrinkwrap to make sure it sticks.

Caveat of my advice is I can't remember if this is exactly what I did, and my knowledge of npm is pretty rough

from isomorphic-fetch.

matthew-andrews avatar matthew-andrews commented on May 31, 2024

Thank you for your suggestion. I think your workaround seems neat enough for what is I imagine to be a fairly obscure use case so I would prefer not to put it into this library if possible. Sorry!

from isomorphic-fetch.

julienvincent avatar julienvincent commented on May 31, 2024

I understand it's unfair to expect you to support other people using your library badly

It's not so much the case of people using the library badly, but rather people being unaware that fetch will break react-native.

I think that this is an issue that should be fixed/handled here as the alternative is filing PR's for every library that depends on fetch in order to use within react-native.

from isomorphic-fetch.

sosaucily avatar sosaucily commented on May 31, 2024

@kenfehling I'm in the same boat, trying to use Redux-API-middlware with reactNative.

Can you elaborate a bit on how you were able to work around the problem? My app blows up when importing from redux-api-middleware. Thx

from isomorphic-fetch.

wolframkriesing avatar wolframkriesing commented on May 31, 2024

How I solved it (one of thousand solutions to this):
Problem was: a package I installed imported two node.js modules, one was import url from 'url'; the other was querystring and the third was isomorphic-fetch. The error message didn't really point me to those in the beginning.
I am now in the process of removing/replacing those dependencies.

from isomorphic-fetch.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.