Incompatibility with Memcached 3 about scrapbook

[martin-georgiev]

Two options I'll consider to solve this situation:

• Check the Memcached version and based on that value decide which arguments to pass. This should be the preferable way to do it.
• Use ReflectionMethod to test for the number of expected arguments. This solution is dirty and shouldn't be considered as a long-term solution, as Memcached's API can change again in the future.

[matthiasmullie]

Hey @martin-georgiev, thanks for the detailed report!

I just pushed a new commit that should fix this issue - any chance you could try it out (it's in master) before I push a new release?

[martin-georgiev]

Thanks @matthiasmullie,
I can confirm that the change is behaving as expected now.

There is a separate, less significant problem. The library will not handle gracefully the case when \Memcached::getMulti() returns false. Such cases will produce an error:

Warning: Invalid argument supplied for foreach() in .../matthiasmullie/scrapbook/src/Adapters/Memcached.php on line 73

I think this should be handled within the Adapters\Memcached (e.g. throwing a descriptive exception).

[matthiasmullie]

Thanks for the PR for that last issue! :)