warning: a function declaration without a prototype is deprecated in all versions of C about lfe

[MatthieuStigler]

Just submitted and... unfortunately, it looks like the warning is still there? see https://win-builder.r-project.org/incoming_pretest/lfe_2.9-0_20230120_092248/Debian/00check.log

./lfe.h:115:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
./lfe.h:116:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
utils.c:231:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
utils.c:244:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]

[pachadotdev]

@pachadotdev , just submittd, and got rejected, but it seems we are getting closer! :-)

Now the message appears only for two lines:

Found the following significant warnings:
utils.c:231:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
utils.c:244:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
See ‘/srv/hornik/tmp/CRAN/lfe.Rcheck/00install.out’ for details.

Do you think you could have a look? Thanks!

sure! it's the R user interruption, let me write a workaround

[pachadotdev]

hi @MatthieuStigler
I have opened a PR that fixes this issue, but also applies proper indentation to the written code

[MatthieuStigler]

Was fixed by @pachadotdev , thanks a lot!!

[pachadotdev]

Just submitted and... unfortunately, it looks like the warning is still there? see https://win-builder.r-project.org/incoming_pretest/lfe_2.9-0_20230120_092248/Debian/00check.log

./lfe.h:115:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
./lfe.h:116:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
utils.c:231:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
utils.c:244:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]

that's a new warning, I'll try to bypass it in a new PR

[MatthieuStigler]

@pachadotdev , just submittd, and got rejected, but it seems we are getting closer! :-)

Now the message appears only for two lines:

Found the following significant warnings:
utils.c:231:19: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
utils.c:244:13: warning: a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
See ‘/srv/hornik/tmp/CRAN/lfe.Rcheck/00install.out’ for details.

Do you think you could have a look? Thanks!

[pachadotdev]

@MatthieuStigler I've uploaded to RHub and Winbuilder to check if the error is gone

[MatthieuStigler]

Thanks! I see you made important non-technical changes to the DESCRIPTION file? I think it would be good to separate the technical commits from those, so that we can discuss them?

[pachadotdev]

yes, let me revert those !!!!!!

[pachadotdev]

Thanks! I see you made important non-technical changes to the DESCRIPTION file? I think it would be good to separate the technical commits from those, so that we can discuss them?

@MatthieuStigler Reverted!! I have my own branch where I added a Poisson GLM. Let's discuss that later.