Comments (5)
Sorry about the inconsistency @aleemb
Were you using the rad.js on the demo or github? The demo's rad.js might be outdated, since I may have only updated the minified version.
Thanks.
from rad.
If it's the demo's rad.js, I'll update it.
from rad.
@aleemb I just tested Rad.js and it seems to work just fine. I've re-copied the JS over to the demo again just to be sure it has the most updated version, but it should all be good.
https://primary-colored.5apps.com/
from rad.
I was referring to the GitHub repo. In rad.js
on line 62 you have:
var pWidth = this.adParent.width();
if(this.options.maxWidth){
In the rad.min.js you have:
var pWidth=this.adParent.width();
pWidth -= parseInt(this.adParent.parent().css("marginLeft").replace("px",""))+parseInt(this.adParent.parent().css("marginRight").replace("px",""));
That bit with the pWidget -= parseInt...
is missing from rad.js
I realized this when I tried to minify rad.js
myself as part of my css build process.
from rad.
Whoa, you're totally right. Sorry I missed that. I thought I updated it before.
Thanks for catching that bug. Great job.
from rad.
Related Issues (5)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rad.