Comments (5)
Hi, @ijabit apologies for the very late response, not ideal but been really busy!
This issue has been addressed but needs to be released. There are a few issues with the json serialising which need ironed out. So far the releases have essentially been pre-release but my eagerness to get everything up and running has resulted in incredibly poor quality management. I hope to have these additional issues fixed and proper tests in place to ensure everything is working as it should prior to the next release.
If you notice any other issues please let me know regardless of if you are using the nuget package or not, really appreciate the input.
Thanks,
Matt
from applemusicapi.net.
Thanks for the response. I have a fork of the code anyways with the workaround I mentioned above in place. I also added the ability to initialize DI with a pre-generated key, instead of requiring the certificate and generating it on the fly. I think it's a nice enhancement if you're interested.
from applemusicapi.net.
Okay I did some digging and found a workaround:
https://github.com/MattPress/AppleMusicAPI.NET/blob/master/src/AppleMusicAPI.NET.Models/Relationships/TrackRelationship.cs
The Relationship class it is inheriting from doesn't have the Playlist generic type parameter. When I make that class inherit from Relationship<Playlist>
it works! But I don't know if the intent was to have this class used from multiple relationships other than Playlist so I'll leave it up to the author to decide what to do about this.
from applemusicapi.net.
Sure, just open a PR!
from applemusicapi.net.
Issue mentioned fixed in ongoing PR #7
from applemusicapi.net.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from applemusicapi.net.