Comments (3)
I'm not sure what you propose exactly. Currently, the algorithm decrements a cell value iff it is non-zero. It is a for-loop, however, so if the first cell is already zero and subsequent ones not, then the algorithms stops immediately. This doesn't affect correctness, because the minimum is used when computing the count.
What should be the expected behavior in your opinion?
from libbf.
I say about that fact that you stop only the first cell value is zero, as I understand. I suggest firstly take sure that any of cell values is non-zero and if all correct to decrement. I agree that we are use minimum so everything correct. But if you decrement and I am not, can we put this down to the fact that we don't necessarily get a 100% correct result? (sorry for poor eng)
from libbf.
I think that's also a valid approach and slight less aggressive. I haven't had a chance to look around, but I wouldn't be surprised if someone sat down and proved the bounds analytically of the various options.
If there is some evidence that it makes sense to have multiple approaches, we can make the decrement algorithm a policy.
from libbf.
Related Issues (20)
- Avoid assert failure on bits_.size() % digests.size() HOT 2
- Path with space
- Possible performance issue when performing look-ups for non-existent entries HOT 3
- N3980: a more flexible way of hashing HOT 3
- make test failure
- how to install the code in os x? HOT 5
- Possible performance improvement by replacing % (modulo) with multiply + shift HOT 3
- Wrapping for Python 3 HOT 6
- Conan package HOT 5
- bits.size % digests.size() assert error make this library not friendly. HOT 3
- Remove dependency on Threads HOT 1
- MSVC not supported? HOT 1
- aux is a reserved file name on windows HOT 3
- Error while building on windows using MSVC HOT 1
- Segmentation fault when running in thread HOT 1
- GCC: Version 10.0.1 "runtime_error’ is not a member of ‘std" in hash.cpp HOT 2
- Incorrect header inclusion
- latest tag release HOT 1
- How can I add raw bytes, or non-null terminated strings? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libbf.