Fails to parse JSON (and create HTML output) on cucumber error about grunt-cucumberjs

[lenntt]

I can confirm this issue.
I tried the workaround, which works... though I'd prefer a stronger regex (since I'm logging objects and array).

I guess this is the part we want to capture:

[
   {
     "elements": [
       {
          "id": ".......",
          .....

[shaneobrien20]

Hi SirLenz0rlot, couldn't agree more about stronger regex.

Try this, seems to work for both:

/\[\s*{\s*\"|\[\"/g

All I added was a pipe in the middle there, searching for either object start or array start. It satisfies the above example but would probably need some more thorough testing.

[lenntt]

To make this more reliable, the whole flow of the json should be improved.

I noticed that when I console.log something in a AfterFeatures handler, the json breaks too :S

[lenntt]

The regex I suggested is a bad one by the way. The first property can as well be a "description"

[gkushang]

@shaneobrien20 @SirLenz0rlot thanks for your inputs. I agree about improving on JSON parsing and do not depend on RegEx for future compatibility.

Let's not parse the JSON based on RegEx, instead read the JSON file created at the end of run. Since Cucumber's formatter -f json: fileName.json writes the JSON for HTML reporting, it can be used to create HTML.

[gkushang]

Hi @shaneobrien20 @SirLenz0rlot - PR #75 will fix the JSON parsing issue as we do not depend on RegEx anymore. Would you guys mind to test it out by pulling the module thru
"grunt-cucumberjs": "git+ssh://[email protected]/gkushang/grunt-cucumberjs.git#tests"
or
npm i git+ssh://[email protected]/gkushang/grunt-cucumberjs.git#tests till it's merged and publish?

[lenntt]

I'm afraid it doesn't work for me.
jsonOutput doesn't seem like valid json to me, as all the console.log() from the test code gets in there too.

I guess this is caused by reading the entire buffer (jsonOutput = Buffer.concat(buffer).toString(); in processHandler)

[lenntt]

Let's get rid of reading from the buffer!

in cucumber.js:35, couldn't we just replace:

                commands.push('-f', 'json');

by

                commands.push('-f', 'json:' + options.output + '.json' );

Then, I think we should remove the saveJson option (since its always true when enabling html) and in processHandler throw if the json doesnt exist instead of trying to read from buffer.

Edit: working on a PR

[gkushang]

@SirLenz0rlot Can you share your cucumberjs "options"?

[gkushang]

Published @0.10.1. Here is the CHANGELOG