GithubHelp home page GithubHelp logo

Comments (3)

mawie81 avatar mawie81 commented on May 23, 2024

Thank you for your feedback 😀

I just had quick look on it and noticed the following:

About the first issue: I could not reproduce the issue on my multi monitor Mac. If I have a second monitor and close the app there I get some correct looking coordinates. When the app is relaunched with only the internal laptop display available it is put automatically on this display. So I assume electron would fix such issues on its own. I did not have the chance to test this on a multi display Windows environment though and will probably only have a chance to on the weekend.
Are you referring to a Windows environment?

About the second issue: At the moment the x and y coordinates are not saved if the window is maximized. I tried to change this and simply always save them. This seemed to work on the Mac but as soon as window.maximize() is called the window just jumps back to the main display.
I will investigate what happens on windows on the weekend in this case as well.

from electron-window-state.

etiktin avatar etiktin commented on May 23, 2024

Yep. I'm using Windows. If it doesn't happen on OS X then I guess either the OS or Electron are fixing the placement. On Windows there are plenty of apps that don't take care of this and the experience for multi-screen users is pretty bad as a result.

I'm currently working on fixing these issues. I'll send a PR later today or tomorrow for your consideration.

from electron-window-state.

krainboltgreene avatar krainboltgreene commented on May 23, 2024

I was able to reproduce on a mac this with another app that doesn't use electron-window-state, so I believe this is something to do with electron itself. I'll make an issue there.

from electron-window-state.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.