Comments (3)
Thank you for your feedback 😀
I just had quick look on it and noticed the following:
About the first issue: I could not reproduce the issue on my multi monitor Mac. If I have a second monitor and close the app there I get some correct looking coordinates. When the app is relaunched with only the internal laptop display available it is put automatically on this display. So I assume electron would fix such issues on its own. I did not have the chance to test this on a multi display Windows environment though and will probably only have a chance to on the weekend.
Are you referring to a Windows environment?
About the second issue: At the moment the x and y coordinates are not saved if the window is maximized. I tried to change this and simply always save them. This seemed to work on the Mac but as soon as window.maximize()
is called the window just jumps back to the main display.
I will investigate what happens on windows on the weekend in this case as well.
from electron-window-state.
Yep. I'm using Windows. If it doesn't happen on OS X then I guess either the OS or Electron are fixing the placement. On Windows there are plenty of apps that don't take care of this and the experience for multi-screen users is pretty bad as a result.
I'm currently working on fixing these issues. I'll send a PR later today or tomorrow for your consideration.
from electron-window-state.
I was able to reproduce on a mac this with another app that doesn't use electron-window-state, so I believe this is something to do with electron itself. I'll make an issue there.
from electron-window-state.
Related Issues (20)
- Store other/custom window state details (e.g. URL)
- Support multiple windows HOT 8
- Looking for maintainers HOT 2
- Specific window size and position are not remembered HOT 2
- App off the screen if user selects a different display as their main and then launches the electron app HOT 3
- Include the type definition file (index.d.ts) into npm package. HOT 1
- Type definition export is incorrect
- Window state saved when second screen disconnected HOT 1
- App launched outside display area when second screen disconnected HOT 5
- Suggestion: saving the open/close state
- WindowState.manage(win) makes BrowserWindow.loadURL() reject promise in electron 5.0.0+ (using 5.0.1)) HOT 4
- BrowswerWindow flashes and then closes
- Resizable results in strange behavior
- Specifying path param won't work
- Window state not persisted anymore HOT 5
- If previously closed with any edge(s) overflows the screen border, window will relaunch at left top corner. HOT 1
- Manage function breaks the ready-to-show event in electron HOT 1
- # HOT 1
- Window size not preserved correctly when multiple displays use different screen scaling (devicePixelRatio) HOT 1
- Try to maintain this lib and checkout here: https://www.npmjs.com/package/stateful-electron-window
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from electron-window-state.