GithubHelp home page GithubHelp logo

Comments (4)

ciffelia avatar ciffelia commented on May 29, 2024 1

IMHO it's impossible to make the config static without requiring the argument of with_name to be static.

from tower-sessions.

maxcountryman avatar maxcountryman commented on May 29, 2024 1

This is resolved via yanking 0.10.4 and publishing 0.11.0. Thanks for reporting it!

from tower-sessions.

maxcountryman avatar maxcountryman commented on May 29, 2024

Unfortunately the reason this worked before is because the method allocated via to_string internally (not so great obviously). The changes in 0.10.4 make it so either a stack or heap allocated value may be used and indeed a &str may be used here. It seems the issue you're running into is that 0.10.4 made the lifetime static. Ultimately we do want the config to be static because we don't want to allocate for what is a constant set of values over the lifetime of the program. Needless to say we do not want to break SemVer (altho it's not clear how to avoid that given the prior release also broke SemVer).

from tower-sessions.

maxcountryman avatar maxcountryman commented on May 29, 2024

I agree. That means we can yank 0.10.4 and republish as 0.11. I don't think there's much else that can be done. If there's a larger problem with that API, with your specific use case, please let me know.

from tower-sessions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.