Warnings during build: `no previous prototype for ‘mbedtls_xor’`, `no previous prototype for ‘mbedtls_put_unaligned_uint16’` etc. about mbedtls

[gilles-peskine-arm]

Maybe related to #8786 ? It looks like we have functions that were intended to be static inline but static is missing.

[tom-cosgrove-arm]

There have been a lot of changes in this area, most recently in PR #8719. Can you try again with development? Several functions were changed from inline to static inline then

[tom-daubney-arm]

@barracuda156 AFAIK we don't actually currently support building with -Wmissing-prototypes and obviously not using this flag gets rid of these warnings, so to answer your original question, I don't think these warnings are of concern.

[tom-daubney-arm]

Hi @barracuda156, is this with a freshly checked-out default config? Thanks

[barracuda156]

Hi @barracuda156, is this with a freshly checked-out default config? Thanks

@tom-daubney-arm I am building from the portfile: https://github.com/macports/macports-ports/blob/d9650bcb2c73bc2993339693855f715134e30bb2/devel/mbedtls3/Portfile
No modifications locally on my end.

The only patch applied from Macports side is related to Python: https://github.com/macports/macports-ports/blob/master/devel/mbedtls3/files/patch-CMakeLists.txt.diff
I believe, that should not be relevant to functions prototypes.

[barracuda156]

Maybe related to #8786 ? It looks like we have functions that were intended to be static inline but static is missing.

Possibly, yes.

[tom-daubney-arm]

I am now closing this issue for the reasons outlined in the comment above which is essentially that we currently don't support builds with the -Wmissing-prototypes flag set.

Edit:- this is not fully correct. Library code does support the flag, however test and program code does not. This issue still needs to be closed since this problem has been taken care of in the latest development branch.

[barracuda156]

@tom-daubney-arm As long as these warnings constitute no problem and are merely triggered by an extra flag, there is no issue indeed. Thank you.
(I am not a maintainer of mdebtls3 port, so I am not sure why that flag is added.)