GithubHelp home page GithubHelp logo

Comments (4)

mbostock avatar mbostock commented on July 17, 2024 1

It looks like the winding order of these polygons is wrong (according to GeoJSON’s expectations):

https://observablehq.com/d/3263eaf199936bc7

It’s possible that MapShaper is correcting that for you, but this shapefile parser doesn’t do that. You should be able to fix this by reversing the coordinates of the some of the polygons and fixing the polygon-hole associations. But like #59 this isn’t really a bug in the parser, it’s just messy data that the parser isn’t fixing for you.

from shapefile.

mbostock avatar mbostock commented on July 17, 2024 1

If I have a moment I’ll see if there’s something smarter we can do with the input to correct the winding order. Thanks for including the test data.

from shapefile.

rdmurphy avatar rdmurphy commented on July 17, 2024

Gotcha. 👍 That makes sense. I'll make sure that's cleared up in post-processing when I'm using shapefile. Got it work already with an extra pass with geojson-rewind: https://observablehq.com/d/4868d7d5d3d0732a

Thank you for taking a look! 👋

from shapefile.

mbostock avatar mbostock commented on July 17, 2024

Folding into #64.

from shapefile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.