Crash w/ Zoology Mod about metamorph

[mchorse]

Thanks for reporting! ☺️

Could you please provide also the Caused by ... section?

[WenXin20]

I was able to get the Crash Report this time
I also noticed that when I morphed back into the player, I get killed.

[mchorse]

@WenXin20 I don't really know what I can do about this error, I will ask mod's developer, though.

[WenXin20]

Ok, thanks

[WenXin20]

Is it possible add a way to prevent the crash and just prevent it from displaying the mob until the real solution can be found since @rwtema seems to be inactive?

[mchorse]

I don't think so. Because this will affect all animal mobs, and I think you wouldn't be able to use animal morphs in survival morph menu too or even morph into animal morphs.

Maybe there's a way, and I'll look into it.

[WenXin20]

Thanks.
While in a creative world, I was able to kill sheep and cows to get their morphs and access the survival morph menu afterwards, so it only seems to affect the creative menu, although I didn't try all mobs that Zoology changes.

[mchorse]

It's happens in creative morph menu, because there's a special way in which morphs are generated for the display. With survival stuff, the entity is first deserialized, and afterward it's serialized, but in creative morph menu, it's first serialized, and then deserialized.

In @rwtema's code, if this list is serialized first, it's an illegal state, it seems like it first have to be deserialized from NBT or generated. Btw, which build of Metamorph are you using (1.10.2, 1.9.4 or 1.11.2)?

[WenXin20]

Ok, and I'm using 1.10.2 v1.1

[mchorse]

@WenXin20 could you test out Zoology and creative morph menu with this build? I think I fixed the issue, but I may be proven wrong.

[WenXin20]

Sorry, but that didn't work, I got the same crash.

[mchorse]

Hm, really strange, after I'll finish the thing I currently working on, I might take a look at testing Metamorph with Zoology mod.

[WenXin20]

Ok, thanks

[mchorse]

@WenXin20 I tried to fix issue with Zoology, and it kind of worked... disabling all of the animal morphs, haha. I can't really do anything besides disabling the morph that erroring since Forge doesn't provide an API to disable capabilities.

@rwtema maybe you can suggest how to fix it?

[WenXin20]

Ok, thanks, that works for me, so that at least the creative menu is accessible now.

[mchorse]

Won't fix, I guess.