Comments (6)
Sure, I'm closing this PR. Reopen when needed.
from sal.
According to IntersectionObserver docs, threshold can be only a number or an array of numbers. Currently, sal.js doesn't support array of numbers. If you could create a demo with this particular issue, maybe I could help.
from sal.
Thank you for your feedback, I try to create a demo of my issue.
from sal.
@mciastek I can't create a demo but this is a real project with the issue : https://www.caveduvaldor.com
Open this link on a small devices view and look at the third section of the page, user think there is no content.
If we can set something like 100px
it will always works but percentage value is an issue if the animated area is very height.
from sal.
The threshold
doesn't accept absolute values, only relative ones - it's mentioned in docs. It's not possible to pass 100px
. You can use only floats or integers here. I can suggest to apply a custom animation to this tall section. The issue here is translate value, which by default is set to 20% of the height. You can add you custom animation, that will use translate with fixed value, like 100px
. Then this section will be shifted down by 100px
and user will need to scroll only 100px to see animation. Let me know if it helps you.
from sal.
@mciastek thank you, I'll try to use a fixed offset ;)
from sal.
Related Issues (20)
- Possible to use Library on div class whitout data-attribute HOT 3
- Animations aren't working on Google Chrome, iOS
- Flicking bug when on the threshold of element HOT 4
- Element stay hidden, animation won't trigger when going to page through <NuxtLink /> HOT 2
- Attach animation to h3 with attributes HOT 1
- Feature Request: Add easing functions to `sal-*` custom properties
- element animated but not visible
- Sal elements on unsupported browsers are completely invisible
- Animations are not working on mobile
- Using sal.js with swiper
- Set default delay and easing in JavaScript
- 340659489-139d1b33-d5e7-4aa8-bf46-d7d9a863f26b.jpg (975×1080)
- Discord
- Using sal.js with WordPress Gutenberg blocks HOT 2
- Can't install the plugin
- The default timing function causes the CLS score to drop significantly in Lighthouse
- Feature Request
- Animations already ran on page load
- sal.js is not working with react. sal is not defined
- sal({...}) overwrites previous call options
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sal.