GithubHelp home page GithubHelp logo

Threshold vs height about sal HOT 6 CLOSED

florianbouvot avatar florianbouvot commented on September 2, 2024
Threshold vs height

from sal.

Comments (6)

mciastek avatar mciastek commented on September 2, 2024 1

Sure, I'm closing this PR. Reopen when needed.

from sal.

mciastek avatar mciastek commented on September 2, 2024

According to IntersectionObserver docs, threshold can be only a number or an array of numbers. Currently, sal.js doesn't support array of numbers. If you could create a demo with this particular issue, maybe I could help.

from sal.

florianbouvot avatar florianbouvot commented on September 2, 2024

Thank you for your feedback, I try to create a demo of my issue.

from sal.

florianbouvot avatar florianbouvot commented on September 2, 2024

@mciastek I can't create a demo but this is a real project with the issue : https://www.caveduvaldor.com

Open this link on a small devices view and look at the third section of the page, user think there is no content.
If we can set something like 100px it will always works but percentage value is an issue if the animated area is very height.

from sal.

mciastek avatar mciastek commented on September 2, 2024

The threshold doesn't accept absolute values, only relative ones - it's mentioned in docs. It's not possible to pass 100px. You can use only floats or integers here. I can suggest to apply a custom animation to this tall section. The issue here is translate value, which by default is set to 20% of the height. You can add you custom animation, that will use translate with fixed value, like 100px. Then this section will be shifted down by 100px and user will need to scroll only 100px to see animation. Let me know if it helps you.

from sal.

florianbouvot avatar florianbouvot commented on September 2, 2024

@mciastek thank you, I'll try to use a fixed offset ;)

from sal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.