GithubHelp home page GithubHelp logo

Comments (17)

orbeckst avatar orbeckst commented on May 31, 2024 1

You are right. However, in this particular case, the test was still a success: It uploaded 0.9.0-rc1 (which had already worked before), and it then successfully downloaded 0.9.0 and ran the tests — and it was really the latter that needed testing.

I'm fine with counting this as a success and moving on to releasing 0.9.0.

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024 1

Created the GitHub release https://github.com/MDAnalysis/MDAnalysisData/releases/tag/release-0.9.0

from mdanalysisdata.

IAlibay avatar IAlibay commented on May 31, 2024

pinging @orbeckst here as the person in the know for this package

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

Deployment workflow would be great (issue #57), not saying that this your job.

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

With all the latest updates to CI, I feel ready for 0.9.0!

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

Holding until PR #68 is merged.

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

Created tag release-0.9.0...

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

Failed: https://github.com/MDAnalysis/MDAnalysisData/actions/runs/6697894849 ...

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

The workflow is not valid. .github/workflows/deploy.yaml (Line: 18, Col: 9): Unexpected end of expression: ')'. Located at position 120 within expression: github.repository == 'MDAnalysis/MDAnalysisData' &&
(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')

... need to fix

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024
  • ✅ TestPypi deployment itself worked https://github.com/MDAnalysis/MDAnalysisData/actions/runs/6698031942/job/18199197552
  • 🔴 Test FAILED
    ==================================== ERRORS ====================================
    _________________ ERROR at setup of test_fetch_remote_sha_fail _________________
    file /home/runner/work/MDAnalysisData/MDAnalysisData/MDAnalysisData/tests/test_base.py, line   107
      def test_fetch_remote_sha_fail(remote_topology, mocker):
    E       fixture 'mocker' not found
    >       available fixtures: bunch, cache, capfd, capfdbinary, caplog, capsys, capsysbinary,   doctest_namespace, monkeypatch, pytestconfig, record_property, record_testsuite_property, record_xml_attribute, recwarn, remote_topology, some_text, tmp_path, tmp_path_factory, tmpdir, tmpdir_factory
    >       use 'pytest --fixtures [testpath]' for help on them.
    

Need to add packages to the test suite.

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

(When do I learn to use "rc" release tags when testing anything with deployment... sigh.)

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

Progress currently blocked by #72 .

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

(Note to self: test deployment with release-0.9.0-rc1, when all good, move the release-0.9.0 tag to HEAD and force-push tags, ignore resulting test.pypi failure, and hope that the upload to pypi works)

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

WIth PR #73 merged we need to check that #72 is really fixed.

  • tag release-0.9.0-rc1
  • check that the testpypi action uploads and completes the test (EDIT: see #62 (comment) — it really downloaded 0.9.0 but the fix from #73 worked)

from mdanalysisdata.

IAlibay avatar IAlibay commented on May 31, 2024

0.9.0-rc1 won't work because pypi will always pick up a full release over an rc one and it's alreayd on testpypi.
You'll have to do 0.9.1-rc1 or alpha.

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

Upload to https://pypi.org/project/MDAnalysisData/0.9.0/ was successful. (Testing in the action did not work as intended because it pulled 0.8.1.). Locally 0.9.0 works.

conda-forge is in progress with PR conda-forge/mdanalysisdata-feedstock#8

from mdanalysisdata.

orbeckst avatar orbeckst commented on May 31, 2024

conda-forge is done.

from mdanalysisdata.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.