Discrepancy in test_views RE permission error tests about django-locallibrary-tutorial

[hamishwillee]

@isherifwilson Thanks very much - good catch. Yes it is inconsistent.

Arguably the behaviour in RenewBookInstancesViewTest is wrong - if you're not logged and you're trying to do something that requires permissions then you should be taken to a login screen to log in - ie the status code will be 302 (redirect). If you are logged in but have the incorrect permissions then you should get 403 forbidden. Redirecting to login again when you're already logged in is annoying

As you say, the default permissions on function and class based views are different (this may have changed since I designed the test). Essentially though we need two decorators in the function view case, and the permission one has to raise an exception:

@login_required
@permission_required('catalog.can_mark_returned', raise_exception=True)
def renew_book_librarian(request, pk):	def renew_book_librarian(request, pk):

I have fixed up the code in #76 and the docs. The test for this case is now: test_forbidden_if_logged_in_but_not_correct_permission