Callback was already called about metalsmith-browser-sync

[claycarpenter]

This issue seems to have been fixed by my PR #5 .

If you want to give it a try on your site, you can use this command:

npm install --save-dev git://github.com/claycarpenter/metalsmith-browser-sync#active-check

[franklinjavier]

@claycarpenter thanks, but... Am I missing something?

npm install --save-dev git://github.com/claycarpenter/metalsmith-browser-sync#active-check
zsh: no matches found: git://github.com/claycarpenter/metalsmith-browser-sync#active-check

[franklinjavier]

Now it worked. I changed the contents manually and it worked.
I'll have repeat this process until our friend accepts your PR.
Thanks mate @claycarpenter

[claycarpenter]

@franklinjavier great! I was just going to reply that I couldn't replicate the error and suggest you make the changes manually. Glad to hear it's working for you.

[franklinjavier]

🍻

[franklinjavier]

@claycarpenter every time I save a file, duplicates the quantity of posts.

[claycarpenter]

@franklinjavier As far as I can tell right now, this looks like an issue with metalsmith-collections when it's run multiple times without a fresh Metalsmith build. It's late and I'm sleepy and stupid, but it looks like the ms-collections plugin adds the matching files it finds to the global (Metalsmith) metadata each time it's run.

I made a very quick hack that fixed the problem by clearing out the metadata.posts collection before each metalsmith-collections run. The "plugin" looks like this:

    .use(function (files, metalsmith, done) {
        var metadata = metalsmith.metadata();
        delete metadata.posts;
        done();
    })

And should be inserted before the metalsmith-collections plugin in the pipeline. I'm not saying this is a smart hack, but it should get you going for the time being.

Considering this issue probably isn't the fault of this metalsmith-browser-sync plugin, we should probably move the conversation over to your repo if you want to continue.

[franklinjavier]

Thanks for the solution.