Comments (2)
There’s no point in supporting the p or wrapper components.
Well, I mean, there are some points. You may know that you are only passing h1
and Alert
currently, but it’s not great that you have to pass an ['h1', 'Alert']
array at compile time to do that?
There are some things we can decide at compile time. And some things at runtime. These are different times.
If you move options to the compile time, you lose abilities.
Say, for example, mdx-components
is changed. All documents compiled by MDX will need rto be cache-busted.
Or say, someone now passes h1
. It won’t work. If we’d do this, we’d need to introduce runtime errors for when people a) pass components that were not listed at compile time, and b) do not pass components that were listed at compile time.
What is the point of this change? If the point is to use a particular complex optimization plugin (a fork of @babel/plugin-transform-react-constant-elements
), well, then a plugin could also do what you want?
from mdx.
Related Issues (20)
- remark-mdx example doesn't work HOT 6
- Provide a CLI based on `unified-args` HOT 6
- mdx 2.3.0 + remark-gfm 4.0.0 breaks tables HOT 6
- no MdastImportVisitor found for html HOT 1
- mdx 3 converts component elements to p tag HOT 4
- Allow javascript expression in markdown links [](myvar.foo}) HOT 2
- `@mdx-js/rollup` stops working on Vite v5 HOT 13
- created a new recma plugin `recma-mdx-escape-missing-components` HOT 11
- created a new recma plugin `recma-mdx-change-props` HOT 6
- Patch version 3.0.0 to 3.0.1 killed all admonitions HOT 2
- react hmr (fast refresh) breaks when deleting all content of a mdx file HOT 5
- Invalid hook call when using react class component in MDX HOT 4
- Useless/bad error message when forgetting to close an element HOT 3
- MDXProvider is invalid after processSync processing when {jsxImportSource: 'vue', providerImportSource: '@mdx-js/vue'} is configured. HOT 2
- Return a VFile with an appropriate extension in the path HOT 5
- Type Error on jsx type with react jsx runtime HOT 7
- MDXProvider not working as expected. HOT 2
- Unable to parse custom heading ids HOT 4
- When importing .mdx file in a .stories.tsx file: Unexpected `FunctionDeclaration` in code: only import/exports are supported HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mdx.