GithubHelp home page GithubHelp logo

Comments (3)

MeAmAnUsername avatar MeAmAnUsername commented on July 30, 2024

Better solution: create a function getErrorNode : Exp -> astId that takes an expression and returns the correct error location for type errors of that expression.
A block returns the last line of the block
A function could return its own name, or maybe a specific type argument if that is return type for the function (or it could keep being just the full expression)
Other expressions should just return themselves.
Example implementation

getErrorNode(exp) = astId(exp).
getErrorNode(Call(_, name, _, _)) = astId(name). // good idea?
getErrorNode(QCall(_, name, _, _)) = astId(name). // good idea?
getErrorNode(exp@Block([])) = astId(exp).
getErrorNode(Block(lines)) = getLastLine(lines).

  getLastLine : list(Exp) -> Exp
  getLastLine([exp]) = astId(exp).
  getLastLine([_|rest@[_|_]]) = getLastLine(rest).

from pie.

MeAmAnUsername avatar MeAmAnUsername commented on July 30, 2024

Given higher priority because this makes it harder to solve the root cause of the incorrect return type (the actual error cannot easily be spotted because the whole block is red)

from pie.

MeAmAnUsername avatar MeAmAnUsername commented on July 30, 2024

Note: using astids as error locations currently does not work, see metaborg/nabl#74

from pie.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.