config object has to be made global about mean

[viczam]

or at least provide a global function (appRequire or something) to require files relative to the project root path

[amoshaviv]

thats interesting since paths are always a big issue, do you have any idea in mind?

[viczam]

We need access to a global method that will do that require.

Either

global.appRequire = function(path) {
  return require(config.root + path);
}

or we can attach this function as a method of the app object, but then we should make app object globally accessible (and I don't see a big issue of that).

[amoshaviv]

I do prefer the global variable approach though, this could save the redundant requirement of the config object, will try to integrate this in the next version

[viczam]

I did the same. The global variable was the app itself. I added the app.require(path) method.

[ilanbiala]

+1, I don't want to have to require config in every place to use API keys and app titles and things like that.

[ilanbiala]

Any progress on the global config?

[lirantal]

surely we can put the config object on the global variable but I'm not sure if that's a very good practice, since anyway I don't see the config parameters being changed dynamically, and its probably anyway better to explicitly require when things are needed

[ilanbiala]

@lirantal it doesn't change, but requiring it in 20 places adds to memory consumption and affects speed, so being able to access config.anyProperty and not have to require it into every file is much better.

[lirantal]

@ilanbiala

1. Do you have anything to back up the memory consumption? AFAIK node is actually caching require()s so performance isn't supposed to be the main reason for doing this chnge
2. I'm not sure if defining globals are a better way convention to use. (in Java as in many other languages for example, you still need to imports classes/libraries that are used through-out your classes) so I'm still not convinced

[ilanbiala]

Still code to run through, still has to check cache, so just leaving it out would be faster anyway and probably save a tiny bit of memory.

[amoshaviv]

After some discussion we decided to stick with the current approach in the new version

[ilanbiala]

Not a big deal, we will adjust as needed.