xow stops working after suspending and waking up the computer about xow

[medusalix]

I've done some testing and it seems like libusb is returning LIBUSB_TRANSFER_NO_DEVICE after waking up the computer. This usually only happens when you physically remove the dongle and causes xow to stop all USB transfers. I'll probably have to make some adjustments to the USB code to handle this case.

[medusalix]

@webodan Please try out the suspend branch (make sure that the updated service definition gets loaded). While I couldn't find a way for xow to recover after a suspend, I made sure that the service restarts when the system wakes up.

[medusalix]

@NoXPhasma and @andreashuetter, could you try this out for me? I made some significant changes to the USB backend (making it simpler) which will definitely need testing. As an inevitable result of fixing the suspend issue, xow does now terminate when you wake from sleep or unplug the dongle and is then restarted automatically by systemd.

[NoXPhasma]

The service stops when the dongle gets removed, but does not restart when I plug in the dongle again.

Mär 15 04:30:31 NoXP-PC systemd[1]: Started Xbox One Wireless Dongle Driver.
Mär 15 04:30:31 NoXP-PC xow[533968]: 2020-03-15 04:30:31 INFO  - xow v0.3-27-g28cbc4d ©Severin v. W.
Mär 15 04:30:31 NoXP-PC xow[533968]: 2020-03-15 04:30:31 INFO  - Dongle plugged in
Mär 15 04:30:31 NoXP-PC xow[533968]: 2020-03-15 04:30:31 INFO  - Wireless address: 62:45:b4:fe:81:16
Mär 15 04:30:31 NoXP-PC xow[533968]: 2020-03-15 04:30:31 INFO  - Dongle initialized
Mär 15 04:30:35 NoXP-PC xow[533968]: 2020-03-15 04:30:35 ERROR - Error in bulk read: LIBUSB_ERROR_NO_DEVICE
Mär 15 04:30:35 NoXP-PC xow[533968]: 2020-03-15 04:30:35 ERROR - Error in bulk read: LIBUSB_ERROR_NO_DEVICE
Mär 15 04:30:35 NoXP-PC systemd[1]: xow.service: Succeeded.

[medusalix]

Make sure that you run systemctl enable xow and systemctl restart xow after installing the branch to reload the service config.

[NoXPhasma]

Yes, I've done that. It just doesn't restart itself after I remove the dongle and reconnect it.

[NoXPhasma]

Okay I found the issue, sudo make install won't install/override the new service file which includes Restart=always. Once I update the service file manually it works.

[medusalix]

It should overwrite them. When I checkout master, do install and then checkout suspend followed by install it replaces the contents of the service.

[NoXPhasma]

I expected the same here as well, but for some reason it didn't. I even tried to install it two times to get sure.

[medusalix]

Oh well, I'm just going to add a notice to run sudo make uninstall before updating to the README to make sure everyone's covered.

[medusalix]

Merged into master (196371d).