Comments (4)
I have a general question for some additional context. Have people reported issues with the current errors? I haven't seen any. I'm trying to think of a time when this would be an issue. Taking the 404
as an example, in this case the error won't be a specific Meilisearch error, but it will be clear what the issue is since the underlying library handling the http requests will show the 404.
I'm just wondering if making a change will add a lot of extra maintenance for not much benefit.
from integration-guides.
Hi @sanders41,
That's an excellent question, indeed. When we first implemented the versionErrorHintMessage
method, we realized that you weren't all aligned on the definition of errors. Moreover, some names like wait_for_task
return a MeilisearchTimeoutError
are not necessarily appropriate.
In addition, we try to remain vigilant and up to date regarding the errors returned in SDKs, as it can save a lot of situations to have clear and concise errors.
But this is more of a reminder and reflection on the subject for now.
from integration-guides.
I think this option is the best:
Transfer errors > 400 and without message to CommunicationError (I am not in favor of this solution)
About MeilisearchError
I know @brunoocasali would like that all other errors inherit from this error (at least in the languages where it is possible).
For the MeilisearchTimeoutError
, I would like to rename it MeilisearchWaitForTaskTimeOut
or something that does not imply the Meilisearch server timed out.
from integration-guides.
I've opened issues in each repository, and I will close this issue now.
I believe this change could be beneficial for the consumers and for the maintainers, since it is going to ensure a concise public API regarding the errors and will make things easier when you try to catch errors in the test suite.
from integration-guides.
Related Issues (20)
- v1.1 code sample changes HOT 4
- Replace docs.meilisearch.com with meilisearch.com/docs in every repository. HOT 6
- Changes regarding Meilisearch v1.2.0 HOT 29
- Add references to the user-agent in the guide about creating a new integration HOT 2
- Avoid mismatch between Meilisearch server and the SDK HOT 15
- Adding a hint in the error messages for compatibility issues with different versions HOT 4
- Write some guidelines about meilisearch integrations into external repositories HOT 5
- v1.2: Code sample changes HOT 2
- Add cloud touch points on SDKs/Integrations repos README HOT 5
- Changes regarding Meilisearch v1.3.0 HOT 4
- Update cloud link HOT 1
- v1.3: Code sample changes HOT 3
- Move dependabot updates to monthly HOT 1
- Changes regarding Meilisearch v1.4.0 HOT 1
- Changes related to Meilisearch v1.5.0 HOT 2
- Changes related to Meilisearch v1.6.0 HOT 11
- Changes related to Meilisearch v1.7.0 HOT 1
- Changes related to Meilisearch v1.8.0 HOT 1
- Changes related to Meilisearch v1.9.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from integration-guides.